PR feedback

Author: erindru

sqlmesh/core/config/connection.py

@@ -196,6 +196,7 @@ def _expand_json_strings_to_concrete_types(cls, data: t.Any) -> t.Any:
             for maybe_json_field_name in cls._get_list_and_dict_field_names():
                 if (value := data.get(maybe_json_field_name)) and isinstance(value, str):
                     # crude JSON check as we dont want to try and parse every string we get
+                    value = value.strip()
                     if value.startswith("{") or value.startswith("["):
                         data[maybe_json_field_name] = from_json(value)
 

tests/core/test_config.py

@@ -1004,7 +1004,7 @@ def test_config_complex_types_supplied_as_json_strings_from_env(tmp_path: Path)
     with mock.patch.dict(
         os.environ,
         {
-            "SQLMESH__GATEWAYS__BIGQUERY__CONNECTION__SCOPES": '["a","b","c"]',
+            "SQLMESH__GATEWAYS__BIGQUERY__CONNECTION__SCOPES": '     ["a","b","c"]',  # note: leading whitespace is deliberate
             "SQLMESH__GATEWAYS__BIGQUERY__CONNECTION__KEYFILE_JSON": '{ "foo": "bar" }',
         },
     ):