Skip to content

Commit 4ff5506

Browse files
authored
add test
1 parent 7cfb218 commit 4ff5506

1 file changed

Lines changed: 36 additions & 0 deletions

File tree

tests/core/test_snapshot_evaluator.py

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
DataObject,
2525
DataObjectType,
2626
InsertOverwriteStrategy,
27+
CommentCreationView,
2728
)
2829
from sqlmesh.core.environment import EnvironmentNamingInfo
2930
from sqlmesh.core.macros import RuntimeStage, macro, MacroEvaluator, MacroFunc
@@ -1519,6 +1520,41 @@ def test_migrate_view(
15191520
)
15201521

15211522

1523+
def test_migrate_view_recreation_not_needed(
1524+
mocker: MockerFixture,
1525+
make_snapshot,
1526+
make_mocked_engine_adapter,
1527+
):
1528+
model = SqlModel(
1529+
name="test_schema.test_model",
1530+
kind=ViewKind(),
1531+
description="my_description",
1532+
query=parse_one("SELECT c, a FROM tbl"),
1533+
)
1534+
snapshot = make_snapshot(model, version="1")
1535+
snapshot.change_category = SnapshotChangeCategory.METADATA
1536+
snapshot.forward_only = False
1537+
1538+
adapter = make_mocked_engine_adapter(EngineAdapter)
1539+
adapter.COMMENT_CREATION_VIEW = CommentCreationView.UNSUPPORTED
1540+
adapter.with_settings = lambda **kwargs: adapter
1541+
mocker.patch(
1542+
"sqlmesh.core.engine_adapter.base.EngineAdapter.get_data_objects",
1543+
return_value=[
1544+
DataObject(
1545+
schema="sqlmesh__test_schema",
1546+
name=f"test_schema__test_model__{snapshot.version}",
1547+
type="view",
1548+
)
1549+
],
1550+
)
1551+
1552+
evaluator = SnapshotEvaluator(adapter)
1553+
evaluator.migrate([snapshot], {}, directly_or_indirectly_modified_snapshots_ids=set())
1554+
1555+
adapter.cursor.execute.assert_not_called()
1556+
1557+
15221558
def test_migrate_snapshot_data_object_type_mismatch(
15231559
mocker: MockerFixture,
15241560
make_snapshot,

0 commit comments

Comments
 (0)