Simplify

Author: VaggelisD

sqlmesh/core/console.py

@@ -499,10 +499,6 @@ def loading_start(self, message: t.Optional[str] = None) -> uuid.UUID:
     def loading_stop(self, id: uuid.UUID) -> None:
         """Stop loading for the given id."""
 
-    @abc.abstractmethod
-    def log_unit_test_results(self, result: ModelTextTestResult) -> None:
-        """Print the unit test results."""
-
 
 class NoopConsole(Console):
     def start_plan_evaluation(self, plan: EvaluatablePlan) -> None:
@@ -782,9 +778,6 @@ def start_destroy(self) -> bool:
     def stop_destroy(self, success: bool = True) -> None:
         pass
 
-    def log_unit_test_results(self, result: ModelTextTestResult) -> None:
-        pass
-
 
 def make_progress_bar(
     message: str,
@@ -1963,7 +1956,7 @@ def _prompt_promote(self, plan_builder: PlanBuilder) -> None:
     def log_test_results(self, result: ModelTextTestResult, target_dialect: str) -> None:
         divider_length = 70
 
-        self.log_unit_test_results(result)
+        self._log_unit_test_results(result)
         self._print("\n")
 
         if result.wasSuccessful():
@@ -1987,7 +1980,7 @@ def log_test_results(self, result: ModelTextTestResult, target_dialect: str) ->
 
     def _captured_unit_test_results(self, result: ModelTextTestResult) -> str:
         with self.console.capture() as capture:
-            self.log_unit_test_results(result)
+            self._log_unit_test_results(result)
         return strip_ansi_codes(capture.get())
 
     def show_sql(self, sql: str) -> None:
@@ -2506,7 +2499,14 @@ def show_linter_violations(
         else:
             self.log_warning(msg)
 
-    def log_unit_test_results(self, result: ModelTextTestResult) -> None:
+    def _log_unit_test_results(self, result: ModelTextTestResult) -> None:
+        """
+        This is a helper method that encapsulates the logic for logging the relevant unittest for the result.
+        The top level method (`log_test_results`) reuses `_log_unit_test_results` differently based on the console.
+
+        Args:
+            result: The unittest test result that contains metrics like num success, fails, ect.
+        """
         tests_run = result.testsRun
         errors = result.errors
         failures = result.failures
@@ -3208,7 +3208,7 @@ def log_test_results(self, result: ModelTextTestResult, target_dialect: str) ->
             )
         else:
             self._print("```")
-            self.log_unit_test_results(result)
+            self._log_unit_test_results(result)
             self._print("```\n\n")
 
             self._print(

sqlmesh/core/test/result.py

@@ -102,17 +102,6 @@ def addSuccess(self, test: unittest.TestCase) -> None:
 
         self.successes.append(test)
 
-    def log_test_report(self) -> None:
-        """
-        Log the test report following unittest's conventions.
-
-        Args:
-            test_duration: The duration of the tests.
-        """
-        from sqlmesh.core.console import get_console
-
-        get_console().log_unit_test_results(self)
-
     def merge(self, other: ModelTextTestResult) -> None:
         if other.successes:
             self.addSuccess(other.successes[0])

tests/core/test_test.py

@@ -2631,7 +2631,7 @@ def test_model_test_text_result_reporting_no_traceback(
             result.addFailure(test, (e.__class__, e, e.__traceback__))
 
     with capture_output() as captured_output:
-        result.log_test_report()
+        get_console().log_test_results(result, "duckdb")
 
     output = captured_output.stdout