feedback

Author: eakmanrq

sqlmesh/core/dialect.py

@@ -27,6 +27,7 @@
 
 if t.TYPE_CHECKING:
     import pandas as pd
+    from pandas.core.frame import _PandasNamedTuple
 
     from sqlglot._typing import E
 
@@ -1073,7 +1074,7 @@ def extend_sqlglot() -> None:
 
 
 def select_from_values(
-    values: t.List[t.Tuple[t.Any, ...]],
+    values: t.List[_PandasNamedTuple],
     columns_to_types: t.Dict[str, exp.DataType],
     batch_size: int = 0,
     alias: str = "t",
@@ -1103,7 +1104,7 @@ def select_from_values(
 
 
 def select_from_values_for_batch_range(
-    values: t.List[t.Tuple[t.Any, ...]],
+    values: t.List[_PandasNamedTuple],
     columns_to_types: t.Dict[str, exp.DataType],
     batch_start: int,
     batch_end: int,

sqlmesh/core/engine_adapter/base.py

@@ -51,6 +51,7 @@
 
 if t.TYPE_CHECKING:
     import pandas as pd
+    from pandas.core.frame import _PandasNamedTuple
 
     from sqlmesh.core._typing import SchemaName, SessionProperties, TableName
     from sqlmesh.core.engine_adapter._typing import (
@@ -262,7 +263,7 @@ def _df_to_source_queries(
             SourceQuery(
                 query_factory=partial(
                     self._values_to_sql,
-                    values=values,  # type: ignore
+                    values=values,
                     columns_to_types=columns_to_types,
                     batch_start=i,
                     batch_end=min(i + batch_size, num_rows),
@@ -1021,9 +1022,7 @@ def create_view(
         query_or_df = self._native_df_to_pandas_df(query_or_df)
 
         if isinstance(query_or_df, pd.DataFrame):
-            values: t.List[t.Tuple[t.Any, ...]] = list(
-                query_or_df.itertuples(index=False, name=None)
-            )
+            values = list(query_or_df.itertuples(index=False, name=None))
             columns_to_types = columns_to_types or self._columns_to_types(query_or_df)
             if not columns_to_types:
                 raise SQLMeshError("columns_to_types must be provided for dataframes")
@@ -1343,7 +1342,7 @@ def _insert_overwrite_by_time_partition(
 
     def _values_to_sql(
         self,
-        values: t.List[t.Tuple[t.Any, ...]],
+        values: t.List[_PandasNamedTuple],
         columns_to_types: t.Dict[str, exp.DataType],
         batch_start: int,
         batch_end: int,

sqlmesh/core/table_diff.py

@@ -85,7 +85,7 @@ def __new__(cls, *args: t.Any, **kwargs: t.Any) -> RowDiff:
 
     @classmethod
     def _resolve_types(cls) -> None:
-        """Pandas is imported by type checking so we need to resolve the types with the real import before instantiating."""
+        # Pandas is imported by type checking so we need to resolve the types with the real import before instantiating
         import pandas as pd  # noqa
 
         cls.model_rebuild()