Skip to content

Commit 3463b3e

Browse files
authored
Apply suggestions from code review
1 parent e22986d commit 3463b3e

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

docs/cloud/features/security/security.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ A few key components of our internal code requirements:
4646

4747
- We used signed Git commits, required approvers, and signed Docker artifacts.
4848
- Each commit to a `main` branch must be approved by someone other than the author.
49-
- We sign commits and register the key with GitHub ([Github Docs](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits))
50-
- Binaries are signed using cosign and OIDC for keyless ([Signing docs](https://docs.sigstore.dev/cosign/signing/overview/)
51-
- Attestations are created to certify an image, enforced with GCP Binary Authorization ([Attestation docs](https://cloud.google.com/binary-authorization/docs/key-concepts#attestations))
49+
- We sign commits and register the key with GitHub ([Github Docs](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)).
50+
- Binaries are signed using cosign and OIDC for keyless ([Signing docs](https://docs.sigstore.dev/cosign/signing/overview/)).
51+
- Attestations are created to certify an image, enforced with GCP Binary Authorization ([Attestation docs](https://cloud.google.com/binary-authorization/docs/key-concepts#attestations)).
5252
- Encryption is a key feature of our security posture and is enforced at each stage of access. For example, the state database automatically encrypts all data. Credentials are also securely encrypted and stored.
5353
- We back up each state database nightly and before upgrades. These backups are stored for 14 days.
5454

@@ -67,7 +67,7 @@ We use GitHub to sign code commits. At the time the code was committed, the PGP
6767

6868
### How do we invalidate PGP keys if someone did steal it and could potentially use it?
6969

70-
Revoke access for the GitHub user account associated with the compromised key and not give them access again until the old PGP key is deprecated and a new key issued.
70+
We would revoke access for the GitHub user account associated with the compromised key and not give it access again until the old PGP key is deprecated and a new key issued.
7171

7272
### If someone steals a laptop, what's our continuity plan in protecting code?
7373

0 commit comments

Comments
 (0)