chore: make ts stricter in extension (#4146)

Author: benfdking

vscode/extension/src/extension.ts

@@ -56,7 +56,7 @@ export async function activate(context: vscode.ExtensionContext) {
     onDidChangePythonInterpreter(async () => {
       await restart()
     }),
-    onDidChangeConfiguration(async (e: vscode.ConfigurationChangeEvent) => {
+    onDidChangeConfiguration(async (_: vscode.ConfigurationChangeEvent) => {
       await restart()
     }),
     registerCommand(`sqlmesh.restart`, async () => {

vscode/extension/src/lsp/lsp.ts

@@ -1,7 +1,6 @@
-import path from "path"
-import { workspace, ExtensionContext, OutputChannel, window, Disposable } from "vscode"
+import { window, OutputChannel, Disposable } from "vscode"
 import { ServerOptions, LanguageClientOptions, LanguageClient, TransportKind } from "vscode-languageclient/node"
-import { sqlmesh_exec, sqlmesh_lsp_exec } from "../utilities/sqlmesh/sqlmesh"
+import { sqlmesh_lsp_exec } from "../utilities/sqlmesh/sqlmesh"
 import { err, isErr, ok, Result } from "../utilities/functional/result"
 import { getWorkspaceFolders } from "../utilities/common/vscodeapi"
 
@@ -14,7 +13,7 @@ export class LSPClient implements Disposable {
         this.client = undefined
     }
 
-    public async start() {
+    public async start(): Promise<Result<undefined, string>> {
         if (!outputChannel) {
             outputChannel = window.createOutputChannel('sqlmesh_actual_lsp_implementation')
         }
@@ -59,7 +58,8 @@ export class LSPClient implements Disposable {
         }
 
         this.client = new LanguageClient('sqlmesh-lsp-example', 'SQLMesh Language Server', serverOptions, clientOptions)
-        this.client.start()
+        await this.client.start()
+        return ok(undefined)
     }
 
     public async restart() {

vscode/extension/src/utilities/common/setup.ts

@@ -15,13 +15,13 @@ export const isErr = <T, E>(result: Result<T, E>): result is { ok: false; error:
 /**
  * returns an ok version `Result<T, E>` from a value `T`
  */
-export const ok = <T, E>(value: T): { ok: true, value: T} => {
+export const ok = <T>(value: T): { ok: true, value: T} => {
     return { ok: true, value }
 }
 
 /**
  * returns an error version `Result<T, E>` from an error `E`
  */
-export const err = <T, E>(error: E): { ok: false, error: E } => {
+export const err = <E>(error: E): { ok: false, error: E } => {
     return { ok: false, error }
 }

vscode/extension/src/utilities/functional/result.ts

@@ -1,8 +1,7 @@
 import path from "path"
 import { traceLog, traceVerbose } from "../common/log"
 import { getInterpreterDetails } from "../common/python"
-import { getWorkspaceFolders } from "../common/vscodeapi"
-import { Result, err, ok } from "../functional/result"
+import { Result, ok } from "../functional/result"
 import { getProjectRoot } from "../common/utilities"
 
 export type sqlmesh_exec = {

vscode/extension/src/utilities/sqlmesh/sqlmesh.ts

@@ -10,9 +10,10 @@
 		"rootDir": "src",
 		"strict": true,   /* enable all strict type-checking options */
 		/* Additional Checks */
-		// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
-		// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
-		// "noUnusedParameters": true,  /* Report errors on unused parameters. */
+		"noImplicitReturns": true,
+		"noFallthroughCasesInSwitch": true,
+		"noUnusedParameters": true,
+		"noUnusedLocals": true,
 		"paths": {
 			"@bus/*": ["../bus/src/*"]
 		}