Skip to content

Commit 2ca245b

Browse files
committed
Remove PyGithub version pin
1 parent 0ccc058 commit 2ca245b

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ dev = [
7676
"psycopg2-binary",
7777
"pydantic",
7878
"PyAthena[Pandas]",
79-
"PyGithub~=2.5.0",
79+
"PyGithub",
8080
"pyperf",
8181
"pyspark~=3.5.0",
8282
"pytest",

tests/integrations/github/cicd/conftest.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,19 @@ def github_client(mocker: MockerFixture):
4141

4242

4343
@pytest.fixture
44-
def make_pull_request_review() -> t.Callable:
44+
def make_pull_request_review(github_client) -> t.Callable:
4545
from github.PullRequestReview import PullRequestReview
4646

4747
def _make_function(username: str, state: str, **kwargs) -> PullRequestReview:
4848
return PullRequestReview(
49-
"test", # type: ignore
49+
github_client.requester,
5050
{},
5151
{
5252
# Name is whatever they provide in their GitHub profile or login as fallback. Always use login.
5353
"user": AttributeDict(name="Unrelated", login=username),
5454
"state": state,
5555
**kwargs,
5656
},
57-
completed=False,
5857
)
5958

6059
return _make_function

0 commit comments

Comments
 (0)