Chore: detect invalid audit refs and raise early (#4323)

Author: georgesittas

sqlmesh/core/model/definition.py

@@ -2478,6 +2478,14 @@ def _create_model(
 
     model.audit_definitions.update(audit_definitions)
 
+    from sqlmesh.core.audit.builtin import BUILT_IN_AUDITS
+
+    # Ensure that all audits referenced in the model are defined
+    available_audits = BUILT_IN_AUDITS.keys() | model.audit_definitions.keys()
+    for referenced_audit, *_ in model.audits:
+        if referenced_audit not in available_audits:
+            raise_config_error(f"Audit '{referenced_audit}' is undefined", location=path)
+
     # Any macro referenced in audits or signals needs to be treated as metadata-only
     statements.extend((audit.query, True) for audit in audit_definitions.values())
     for _, audit_args in model.audits:

tests/core/test_model.py

@@ -1342,7 +1342,18 @@ def test_audits():
     """
     )
 
-    model = load_sql_based_model(expressions, path=Path("./examples/sushi/models/test_model.sql"))
+    audit_definitions = {
+        audit_name: load_audit(
+            d.parse(f"AUDIT (name {audit_name}); SELECT 1 WHERE FALSE"), dialect="duckdb"
+        )
+        for audit_name in ("audit_a", "audit_b", "audit_c")
+    }
+
+    model = load_sql_based_model(
+        expressions,
+        path=Path("./examples/sushi/models/test_model.sql"),
+        audit_definitions=audit_definitions,
+    )
     assert model.audits == [
         ("audit_a", {}),
         ("audit_b", {"key": exp.Literal.string("value")}),
@@ -9635,3 +9646,19 @@ def test_semicolon_is_not_included_in_model_state(tmp_path, assert_exp_eq):
     plan = ctx.plan(no_prompts=True, auto_apply=True)
 
     assert not plan.context_diff.modified_snapshots
+
+
+def test_invalid_audit_reference():
+    sql = """
+    MODEL (
+      name test,
+      audits (not_nulll (columns := (id)))
+    );
+
+    SELECT
+      1 AS id
+    """
+    expressions = d.parse(sql)
+
+    with pytest.raises(ConfigError, match="Audit 'not_nulll' is undefined"):
+        load_sql_based_model(expressions)