Report 0 rows correctly

Author: treysp

sqlmesh/core/console.py

@@ -4189,15 +4189,15 @@ def _create_evaluation_model_annotation(
     if execution_stats:
         rows_processed = execution_stats.total_rows_processed
         execution_stats_str += (
-            f"{_abbreviate_integer_count(rows_processed)} row{'s' if rows_processed > 1 else ''}"
-            if rows_processed
+            f"{_abbreviate_integer_count(rows_processed)} row{'s' if rows_processed != 1 else ''}"
+            if rows_processed is not None and rows_processed >= 0
             else ""
         )
 
         bytes_processed = execution_stats.total_bytes_processed
         execution_stats_str += (
             f"{', ' if execution_stats_str else ''}{_format_bytes(bytes_processed)}"
-            if bytes_processed
+            if bytes_processed is not None and bytes_processed >= 0
             else ""
         )
     execution_stats_str = f" ({execution_stats_str})" if execution_stats_str else ""
@@ -4306,7 +4306,7 @@ def _calculate_annotation_str_len(
 # Convert number of bytes to a human-readable string
 # https://github.com/dbt-labs/dbt-adapters/blob/34fd178539dcb6f82e18e738adc03de7784c032f/dbt-bigquery/src/dbt/adapters/bigquery/connections.py#L165
 def _format_bytes(num_bytes: t.Optional[int]) -> str:
-    if num_bytes and num_bytes >= 0:
+    if num_bytes is not None and num_bytes >= 0:
         if num_bytes < 1024:
             return f"{num_bytes} bytes"
 
@@ -4324,7 +4324,7 @@ def _format_bytes(num_bytes: t.Optional[int]) -> str:
 # Abbreviate integer count. Example: 1,000,000,000 -> 1b
 # https://github.com/dbt-labs/dbt-adapters/blob/34fd178539dcb6f82e18e738adc03de7784c032f/dbt-bigquery/src/dbt/adapters/bigquery/connections.py#L178
 def _abbreviate_integer_count(count: t.Optional[int]) -> str:
-    if count and count >= 0:
+    if count is not None and count >= 0:
         if count < 1000:
             return str(count)
 

tests/core/engine_adapter/integration/test_integration.py

@@ -6,12 +6,13 @@
 import sys
 import typing as t
 import shutil
-from datetime import datetime, timedelta
+from datetime import date, datetime, timedelta
 from unittest.mock import patch
 import numpy as np  # noqa: TID253
 import pandas as pd  # noqa: TID253
 import pytest
 import pytz
+import time_machine
 from sqlglot import exp, parse_one
 from sqlglot.optimizer.normalize_identifiers import normalize_identifiers
 from sqlglot.optimizer.qualify_columns import quote_identifiers
@@ -2429,6 +2430,24 @@ def capture_execution_stats(
             assert actual_execution_stats["incremental_model"].total_bytes_processed
             assert actual_execution_stats["full_model"].total_bytes_processed
 
+    # run that loads 0 rows in incremental model
+    with patch.object(
+        context.console, "update_snapshot_evaluation_progress", capture_execution_stats
+    ):
+        with time_machine.travel(date.today() + timedelta(days=1)):
+            context.run()
+
+    if ctx.engine_adapter.SUPPORTS_QUERY_EXECUTION_TRACKING:
+        assert actual_execution_stats["incremental_model"].total_rows_processed == 0
+        # snowflake doesn't track rows for CTAS
+        assert actual_execution_stats["full_model"].total_rows_processed == (
+            None if ctx.mark.startswith("snowflake") else 3
+        )
+
+        if ctx.mark.startswith("bigquery"):
+            assert actual_execution_stats["incremental_model"].total_bytes_processed
+            assert actual_execution_stats["full_model"].total_bytes_processed
+
     # make and validate unmodified dev environment
     no_change_plan: Plan = context.plan_builder(
         environment="test_dev",