fix(lsp): context is singleton in vscode

Author: benfdking

sqlmesh/lsp/main.py

@@ -106,10 +106,14 @@ def _create_lsp_context(self, paths: t.List[Path]) -> t.Optional[LSPContext]:
             A new LSPContext instance wrapping the created context, or None if creation fails
         """
         try:
-            context = self.context_class(paths=paths)
-            lsp_context = LSPContext(context)
-            self.lsp_context = lsp_context
-            return lsp_context
+            context = None
+            if self.lsp_context is None:
+                context = self.context_class(paths=paths)
+            else:
+                self.lsp_context.context.load()
+                context = self.lsp_context.context
+            self.lsp_context = LSPContext(context)
+            return self.lsp_context
         except Exception as e:
             self.server.log_trace(f"Error creating context: {e}")
             return None
@@ -293,8 +297,12 @@ def did_open(ls: LanguageServer, params: types.DidOpenTextDocumentParams) -> Non
 
         @self.server.feature(types.TEXT_DOCUMENT_DID_CHANGE)
         def did_change(ls: LanguageServer, params: types.DidChangeTextDocumentParams) -> None:
+            if self.lsp_context is None:
+                current_path = Path.cwd()
+                self._ensure_context_in_folder(current_path)
             uri = URI(params.text_document.uri)
             context = self._context_get_or_load(uri)
+
             models = context.map[uri.to_path()]
             if models is None or not isinstance(models, ModelTarget):
                 return
@@ -731,9 +739,8 @@ def _ensure_context_for_document(
         for a config.py or config.yml file in the parent directories.
         """
         if self.lsp_context is not None:
-            context = self.lsp_context
-            context.context.load()  # Reload or refresh context
-            self.lsp_context = LSPContext(context.context)
+            self.lsp_context.context.load()
+            self.lsp_context = LSPContext(self.lsp_context.context)
             return
 
         # No context yet: try to find config and load it

vscode/extension/tests/utils.ts

@@ -5,7 +5,7 @@ import { _electron as electron, Page } from '@playwright/test'
 
 // Absolute path to the VS Code executable you downloaded in step 1.
 export const VS_CODE_EXE = fs.readJsonSync(
-  '.vscode-test/paths.json',
+  path.join(__dirname, '..', '.vscode-test', 'paths.json'),
 ).executablePath
 // Where your extension lives on disk
 export const EXT_PATH = path.resolve(__dirname, '..')

vscode/react/src/pages/lineage.tsx

@@ -73,8 +73,9 @@ function Lineage() {
   const { on } = useEventBus()
   const queryClient = useQueryClient()
 
-  const { data: models, isLoading: isLoadingModels } = useApiModels()
+  const { data: models, isLoading: isLoadingModels, error } = useApiModels()
   const rpc = useRpc()
+
   React.useEffect(() => {
     const fetchFirstTimeModelIfNotSet = async (
       models: Model[],
@@ -143,6 +144,19 @@ function Lineage() {
     }
   }, [on, queryClient, modelsRecord])
 
+  console.log(
+    'thigns',
+    isLoadingModels,
+    models,
+    modelsRecord,
+    selectedModel,
+    error,
+  )
+
+  if (error) {
+    return <div>Error: {JSON.stringify(error.message)}</div>
+  }
+
   if (
     isLoadingModels ||
     models === undefined ||