-
Notifications
You must be signed in to change notification settings - Fork 380
Expand file tree
/
Copy pathdiagnostics.spec.ts
More file actions
364 lines (305 loc) · 11.3 KB
/
diagnostics.spec.ts
File metadata and controls
364 lines (305 loc) · 11.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
import { expect, test } from './fixtures'
import path from 'path'
import fs from 'fs-extra'
import os from 'os'
import { runCommand, SUSHI_SOURCE_PATH } from './utils'
import { createPythonInterpreterSettingsSpecifier } from './utils_code_server'
import { execAsync } from '../src/utilities/exec'
import yaml from 'yaml'
test('Workspace diagnostics show up in the diagnostics panel', async ({
page,
sharedCodeServer,
}) => {
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'vscode-test-sushi-'))
await fs.copy(SUSHI_SOURCE_PATH, tempDir)
await createPythonInterpreterSettingsSpecifier(tempDir)
const configPath = path.join(tempDir, 'config.py')
const configContent = await fs.readFile(configPath, 'utf8')
const updatedContent = configContent.replace('enabled=False', 'enabled=True')
await fs.writeFile(configPath, updatedContent)
await page.goto(
`http://127.0.0.1:${sharedCodeServer.codeServerPort}/?folder=${tempDir}`,
)
// Wait for the models folder to be visible
await page.waitForSelector('text=models')
// Click on the models folder, excluding external_models
await page
.getByRole('treeitem', { name: 'models', exact: true })
.locator('a')
.click()
// Open the customer_revenue_lifetime model
await page
.getByRole('treeitem', { name: 'customers.sql', exact: true })
.locator('a')
.click()
// Open problems panel
await runCommand(page, 'View: Focus Problems')
await page.waitForSelector('text=problems')
await page.waitForSelector('text=All models should have an owner')
})
test.describe('Bad config.py/config.yaml file issues', () => {
const setup = async (tempDir: string) => {
// Run the sqlmesh CLI from the root of the repo using the local path
const sqlmeshCliPath = path.resolve(__dirname, '../../../.venv/bin/sqlmesh')
const result = await execAsync(sqlmeshCliPath, ['init', 'duckdb'], {
cwd: tempDir,
})
expect(result.exitCode).toBe(0)
}
test('sqlmesh init, then corrupted config.yaml, bad yaml', async ({
page,
sharedCodeServer,
}) => {
const tempDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-tcloud-'),
)
await setup(tempDir)
await createPythonInterpreterSettingsSpecifier(tempDir)
const configYamlPath = path.join(tempDir, 'config.yaml')
// Write an invalid YAML to config.yaml
await fs.writeFile(configYamlPath, 'invalid_yaml; asdfasudfy')
await page.goto(
`http://127.0.0.1:${sharedCodeServer.codeServerPort}/?folder=${tempDir}`,
)
await page.waitForLoadState('networkidle')
// Open full_model.sql model
await page
.getByRole('treeitem', { name: 'models', exact: true })
.locator('a')
.click()
await page
.getByRole('treeitem', { name: 'full_model.sql', exact: true })
.locator('a')
.click()
// Wait for the error to appear
await page.waitForSelector('text=Error creating context')
// Open the problems view
await runCommand(page, 'View: Focus Problems')
// Asser that the error is present in the problems view
await page
.getByText('Invalid YAML configuration:')
.first()
.isVisible({ timeout: 5_000 })
})
test('sqlmesh init, then corrupted config.yaml, bad parameters', async ({
page,
sharedCodeServer,
}) => {
const tempDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-tcloud-'),
)
await setup(tempDir)
await createPythonInterpreterSettingsSpecifier(tempDir)
const configYamlPath = path.join(tempDir, 'config.yaml')
// Write an invalid YAML to config.yaml
const config = {
gateway: 'test',
}
// Write config to the yaml file
await fs.writeFile(configYamlPath, yaml.stringify(config))
await page.goto(
`http://127.0.0.1:${sharedCodeServer.codeServerPort}/?folder=${tempDir}`,
)
await page.waitForLoadState('networkidle')
// Open full_model.sql model
await page
.getByRole('treeitem', { name: 'models', exact: true })
.locator('a')
.click()
await page
.getByRole('treeitem', { name: 'full_model.sql', exact: true })
.locator('a')
.click()
// Wait for the error to appear
await page.waitForSelector('text=Error creating context')
// Open the problems view
await runCommand(page, 'View: Focus Problems')
// Asser that the error is present in the problems view
await page
.getByText('Invalid project config:', { exact: true })
.first()
.isVisible({ timeout: 5_000 })
})
test('sushi example, correct python, bad config', async ({
page,
sharedCodeServer,
}) => {
const tempDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-tcloud-'),
)
await fs.copy(SUSHI_SOURCE_PATH, tempDir)
await createPythonInterpreterSettingsSpecifier(tempDir)
const configPyPath = path.join(tempDir, 'config.py')
// Write an invalid Python to config.py
await fs.writeFile(configPyPath, 'config = {}')
await page.goto(
`http://127.0.1:${sharedCodeServer.codeServerPort}/?folder=${tempDir}`,
)
await page.waitForLoadState('networkidle')
// Open customers.sql model
await page
.getByRole('treeitem', { name: 'models', exact: true })
.locator('a')
.click()
await page
.getByRole('treeitem', { name: 'customers.sql', exact: true })
.locator('a')
.click()
// Expect the error to appear
await page.waitForSelector('text=Error creating context')
// Open the problems view
await runCommand(page, 'View: Focus Problems')
// Assert that the error is present in the problems view
const errorElement = page
.getByText('Config needs to be a valid object of type')
.first()
await expect(errorElement).toBeVisible({ timeout: 5000 })
})
test('sushi example, bad config.py', async ({ page, sharedCodeServer }) => {
const tempDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-tcloud-'),
)
await fs.copy(SUSHI_SOURCE_PATH, tempDir)
await createPythonInterpreterSettingsSpecifier(tempDir)
const configPyPath = path.join(tempDir, 'config.py')
// Write an invalid Python to config.py
await fs.writeFile(configPyPath, 'invalid_python_code = [1, 2, 3')
await page.goto(
`http://127.0.1:${sharedCodeServer.codeServerPort}/?folder=${tempDir}`,
)
await page.waitForLoadState('networkidle')
// Open customers.sql model
await page
.getByRole('treeitem', { name: 'models', exact: true })
.locator('a')
.click()
await page
.getByRole('treeitem', { name: 'customers.sql', exact: true })
.locator('a')
.click()
// Expect the error to appear
await page.waitForSelector('text=Error creating context')
// Open the problems view
await runCommand(page, 'View: Focus Problems')
// Assert that the error is present in the problems view
const errorElement = page.getByText('Failed to load config file:').first()
await expect(errorElement).toBeVisible({ timeout: 5000 })
})
})
test.describe('Diagnostics for bad SQLMesh models', () => {
test('duplicate model names', async ({ page, sharedCodeServer }) => {
const tempDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-tcloud-'),
)
// Copy over the sushi project
await fs.copy(SUSHI_SOURCE_PATH, tempDir)
await createPythonInterpreterSettingsSpecifier(tempDir)
// Duplicate the customers.sql model
const customersSqlPath = path.join(tempDir, 'models', 'customers.sql')
const duplicatedCustomersSqlPath = path.join(
tempDir,
'models',
'customers_duplicated.sql',
)
await fs.copy(customersSqlPath, duplicatedCustomersSqlPath)
await page.goto(
`http://127.0.0.1:${sharedCodeServer.codeServerPort}/?folder=${tempDir}`,
)
await page.waitForLoadState('networkidle')
// Open full_model.sql model
await page
.getByRole('treeitem', { name: 'models', exact: true })
.locator('a')
.click()
await page
.getByRole('treeitem', { name: 'customers.sql', exact: true })
.locator('a')
.click()
// Wait for the error to appear
await page.waitForSelector('text=Error creating context')
// Open the problems view
await runCommand(page, 'View: Focus Problems')
// Asser that the error is present in the problems view
await page
.getByText('Duplicate SQLMesh model name')
.first()
.isVisible({ timeout: 5_000 })
})
test('bad model block', async ({ page, sharedCodeServer }) => {
const tempDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-tcloud-'),
)
// Copy over the sushi project
await fs.copy(SUSHI_SOURCE_PATH, tempDir)
await createPythonInterpreterSettingsSpecifier(tempDir)
// Add a model with a bad model block
const customersSqlPath = path.join(tempDir, 'models', 'bad_model.sql')
const contents =
'MODEL ( name sushi.bad_block, test); SELECT * FROM sushi.customers'
await fs.writeFile(customersSqlPath, contents)
await page.goto(
`http://127.0.0.1:${sharedCodeServer.codeServerPort}/?folder=${tempDir}`,
)
await page.waitForLoadState('networkidle')
// Open the customers.sql model
await page
.getByRole('treeitem', { name: 'models', exact: true })
.locator('a')
.click()
await page
.getByRole('treeitem', { name: 'customers.sql', exact: true })
.locator('a')
.click()
// Wait for the error to appear
await page.waitForSelector('text=Error creating context')
// Open the problems view
await runCommand(page, 'View: Focus Problems')
// Assert error is present in the problems view
const errorElement = page
.getByText("Required keyword: 'value' missing for")
.first()
await expect(errorElement).toBeVisible({ timeout: 5000 })
})
})
test.describe('Diagnostics for bad audits', () => {
test('bad audit block in audit', async ({ page, sharedCodeServer }) => {
const tempDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-tcloud-'),
)
// Copy over the sushi project
await fs.copy(SUSHI_SOURCE_PATH, tempDir)
await createPythonInterpreterSettingsSpecifier(tempDir)
// Make an existing audit file a bad audit
const auditFilePath = path.join(
tempDir,
'audits',
'assert_item_price_above_zero.sql',
)
const readFile = await fs.readFile(auditFilePath, 'utf8')
const updatedContent = readFile.replace('AUDIT (', 'AUDIT ( rubbish value,')
await fs.writeFile(auditFilePath, updatedContent)
// Navigate to the code-server instance
await page.goto(
`http://127.0.1:${sharedCodeServer.codeServerPort}/?folder=${tempDir}`,
)
await page.waitForLoadState('networkidle')
// Open a the customers.sql model
await page
.getByRole('treeitem', { name: 'models', exact: true })
.locator('a')
.click()
await page
.getByRole('treeitem', { name: 'customers.sql', exact: true })
.locator('a')
.click()
// Wait for the error to appear
await page.waitForSelector('text=Error creating context')
// Open the problems view
await runCommand(page, 'View: Focus Problems')
// Assert that the error is present in the problems view
const errorElement = page
.getByText("Invalid extra fields {'rubbish'} in the audit definition")
.first()
await expect(errorElement).toBeVisible({ timeout: 5000 })
})
})