Add Unit Tests for NuspecHandler, in the nuspec update with new style version: 3.25.7.2-build20398

Author: sunnamed434

src/UnturnedRedistUpdateTool/NuspecHandler.cs

@@ -24,5 +24,10 @@ public void UpdateVersion(string newVersion)
         versionElement.Value = newVersion;
     }
 
+    public string CreateVersion(string version, string buildId)
+    {
+        return $"{version}-build{buildId}";
+    }
+
     public void Save() => _doc.Save(_nuspecFilePath);
 }

src/UnturnedRedistUpdateTool/Program.cs

@@ -87,20 +87,22 @@ private static async Task<int> Main(string[] args)
             Console.WriteLine("Version element not found in nuspec file!");
             return 1;
         }
+        var newVersionWithBuildId = nuspecHandler.CreateVersion(newVersion, buildId);
         Console.WriteLine($"Current nuspec version: {currentNuspecVersion}");
-        if (newVersion == currentNuspecVersion)
+        Console.WriteLine($"New Version & Build Id: {newVersionWithBuildId}");
+        if (newVersionWithBuildId == currentNuspecVersion)
         {
             Console.WriteLine("Unturned Version is the same as in nuspec, it means new version is not detected, skipping...");
             return 1;
         }
-        nuspecHandler.UpdateVersion(newVersion);
+        nuspecHandler.UpdateVersion(newVersionWithBuildId);
         nuspecHandler.Save();
 
         var redistUpdater = new RedistUpdater(managedDirectory, redistPath);
         var updatedFiles = await redistUpdater.UpdateAsync();
         if (updatedFiles.Count == 0)
         {
-            Console.WriteLine($"No one file were updated, perhaps something went wrong.");
+            Console.WriteLine("No one file were updated, perhaps something went wrong.");
             return 1;
         }
 

tests/UnturnedRedistUpdateTool.Tests/NuspecHandlerTests.cs

@@ -0,0 +1,52 @@
+using Shouldly;
+using UnturnedRedistUpdateTool.Tests.Helpers;
+using Xunit;
+
+namespace UnturnedRedistUpdateTool.Tests;
+
+public class NuspecHandlerTests
+{
+    private readonly string _testDataDir = Path.Combine(AppContext.BaseDirectory, "TestData", "Redist");
+    private readonly string _realNuspecPath;
+
+    public NuspecHandlerTests()
+    {
+        _realNuspecPath = Path.Combine(_testDataDir, "Test.Unturned.Redist.Client.nuspec");
+        if (!File.Exists(_realNuspecPath))
+            throw new FileNotFoundException($"Test nuspec file not found at {_realNuspecPath}");
+    }
+
+    [Fact]
+    public void GetVersion_ShouldReturnCurrentVersion()
+    {
+        var handler = new NuspecHandler(_realNuspecPath);
+        var version = handler.GetVersion();
+        version.ShouldNotBeNullOrEmpty();
+        version.ShouldStartWith("3.");
+    }
+
+    [Fact]
+    public void UpdateVersion_ShouldModifyVersionElement()
+    {
+        using var tempDir = new TempDir();
+        var tempNuspecPath = Path.Combine(tempDir.Path, Path.GetFileName(_realNuspecPath));
+        File.Copy(_realNuspecPath, tempNuspecPath);
+
+        var handler = new NuspecHandler(tempNuspecPath);
+
+        var newVersion = "1.0.0-test";
+        handler.UpdateVersion(newVersion);
+        handler.Save();
+
+        var reloadedHandler = new NuspecHandler(tempNuspecPath);
+        reloadedHandler.GetVersion().ShouldBe(newVersion);
+    }
+
+    [Fact]
+    public void CreateVersion_ShouldReturnCorrectFormat()
+    {
+        var handler = new NuspecHandler(_realNuspecPath);
+        var result = handler.CreateVersion("3.25.7.2", "20398");
+        result.ShouldBe("3.25.7.2-build20398");
+    }
+}

tests/UnturnedRedistUpdateTool.Tests/TestData/Redist/Test.Unturned.Redist.Client.nuspec

@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="utf-8"?>
+<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
+  <metadata>
+    <id>RocketModFix.Unturned.Redist.Client</id>
+    <version>3.25.7.1</version>
+    <description>
+      Unturned 3 Client-side redistributables. Standalone and always up-to-date.
+    </description>
+    <authors>SmartlyDressedGames;RocketModFix</authors>
+    <license type="file">LICENSE.txt</license>
+    <requireLicenseAcceptance>false</requireLicenseAcceptance>
+    <repository type="git" url="https://github.com/RocketModFix/RocketModFix.Unturned.Redist" />
+    <readme>README.md</readme>
+  </metadata>
+  <files>
+    <!-- Common files for all frameworks -->
+    <file src="LICENSE.txt" target="" />
+    <file src="..\..\README.md" target="README.md" />
+
+    <!-- Files for .NET Framework 4.0 -->
+    <file src="*.dll" target="lib/net40" />
+    <file src="*.xml" target="lib/net40" />
+
+    <!-- Files for .NET Framework 4.8 -->
+    <file src="*.dll" target="lib/net48" />
+    <file src="*.xml" target="lib/net48" />
+
+    <!-- Files for .NET Standard 2.0 -->
+    <file src="*.dll" target="lib/netstandard2.0" />
+    <file src="*.xml" target="lib/netstandard2.0" />
+
+    <!-- Files for .NET Standard 2.1 -->
+    <file src="*.dll" target="lib/netstandard2.1" />
+    <file src="*.xml" target="lib/netstandard2.1" />
+  </files>
+</package>

tests/UnturnedRedistUpdateTool.Tests/UnturnedRedistUpdateTool.Tests.csproj

@@ -13,7 +13,7 @@
 
   <ItemGroup>
     <None Update="TestData\**\*.*">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
   </ItemGroup>