Update how we stringify parameters

The `PlaceholderFormatter` did not call the modifiers when the value was a
string, and the pipe was null. That’s not up to that class to decide, but to the
modifiers themselves to decide whether they can handle the value of the
parameter or not.

Another issue was that the `StringifyModifier` did not stringify values that
were strings containing control characters. That led to cryptic formatting,
since we couldn’t see those characters when the message was displayed.

Assisted-by: OpenCode (GLM-4.6)

Author: henriquemoody

composer.json

@@ -3,20 +3,21 @@
     "type": "library",
     "description": "A powerful and flexible way of formatting and transforming strings",
     "require": {
-        "symfony/polyfill-mbstring": "^1.33",
         "php": "^8.5",
+        "ext-ctype": "*",
         "respect/stringifier": "^3.0",
+        "symfony/polyfill-mbstring": "^1.33",
         "symfony/translation-contracts": "^3.6"
     },
     "suggest": {
         "symfony/translation": "For translation support in TransModifier (^6.0|^7.0)"
     },
     "require-dev": {
-        "phpunit/phpunit": "^12.5",
-        "phpstan/phpstan": "^2.1",
         "phpstan/extension-installer": "^1.4",
+        "phpstan/phpstan": "^2.1",
         "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpstan/phpstan-phpunit": "^2.0",
+        "phpunit/phpunit": "^12.5",
         "respect/coding-standard": "^5.0",
         "symfony/translation": "^6.0|^7.0"
     },
@@ -48,6 +49,7 @@
         "allow-plugins": {
             "phpstan/extension-installer": true,
             "dealerdirect/phpcodesniffer-composer-installer": true
-        }
+        },
+        "sort-packages": true
     }
 }

src/Modifiers/StringifyModifier.php

@@ -8,6 +8,7 @@
 use Respect\Stringifier\HandlerStringifier;
 use Respect\Stringifier\Stringifier;
 
+use function ctype_cntrl;
 use function is_string;
 use function sprintf;
 
@@ -27,7 +28,7 @@ public function modify(mixed $value, string|null $pipe): string
             throw new InvalidModifierPipeException(sprintf('"%s" is not recognized as a valid pipe', $pipe));
         }
 
-        if (is_string($value)) {
+        if (is_string($value) && !ctype_cntrl($value)) {
             return $value;
         }
 

src/PlaceholderFormatter.php

@@ -10,7 +10,6 @@
 use Respect\StringFormatter\Modifiers\TransModifier;
 
 use function array_key_exists;
-use function is_string;
 use function preg_replace_callback;
 
 final readonly class PlaceholderFormatter implements Formatter
@@ -57,11 +56,6 @@ private function processPlaceholder(array $matches, array $parameters): string
             return $placeholder;
         }
 
-        $value = $parameters[$name];
-        if (is_string($value) && $pipe === null) {
-            return $value;
-        }
-
-        return $this->modifier->modify($value, $pipe);
+        return $this->modifier->modify($parameters[$name], $pipe);
     }
 }

tests/Unit/Modifiers/StringifyModifierTest.php

@@ -31,6 +31,7 @@ public static function providerForModifiableValues(): array
             'object value' => [(object) ['key' => 'value']],
             'empty array' => [[]],
             'resource' => [fopen('php://memory', 'r')],
+            'control characters' => ["\n\r\t"],
         ];
     }
 

tests/Unit/PlaceholderFormatterTest.php

@@ -402,6 +402,18 @@ public function itShouldAcceptCustomModifier(): void
         self::assertSame($expected, $actual);
     }
 
+    #[Test]
+    public function itShouldAlwaysCallModifierWhenParameterExists(): void
+    {
+        $modifier = new TestingModifier('modified');
+        $placeholder = 'name';
+
+        $formatter = new PlaceholderFormatter([$placeholder => 'John'], $modifier);
+        $actual = $formatter->format(sprintf('Hello {{%s}}!', $placeholder));
+
+        self::assertSame('Hello modified!', $actual);
+    }
+
     /** @param array<string, mixed> $parameters */
     #[Test]
     #[DataProvider('providerForRealWorldUseCases')]