From ba1487bda94be4be4b0aeddf90ad7a4e7c24bb13 Mon Sep 17 00:00:00 2001 From: gobhardw Date: Mon, 23 Jun 2025 21:19:30 +0530 Subject: [PATCH 1/4] rocprofv3-avail scrip fix --- projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py b/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py index f0932a9fa72..6a56e89004c 100755 --- a/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py +++ b/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py @@ -468,6 +468,8 @@ def main(argv=None): "ROCPROF_LIST_AVAIL_TOOL_LIBRARY", ROCPROF_LIST_AVAIL_TOOL_LIBRARY ) args = parse_arguments(argv) + if argv is None or len(argv) == 0: + avail.fatal_error("No arguments provided") if args.command: args.func(args) From 847aae05eda3905abd6f3f80a40f099bcbea350b Mon Sep 17 00:00:00 2001 From: gobhardw Date: Tue, 5 Aug 2025 13:43:35 +0530 Subject: [PATCH 2/4] addressing feedback --- projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py b/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py index 6a56e89004c..e5770e691d5 100755 --- a/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py +++ b/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py @@ -458,6 +458,9 @@ def process_qualifiers(pmc): def main(argv=None): + if argv is None or len(argv) == 0: + avail.fatal_error("No arguments provided") + ROCPROFV3_AVAIL_DIR = os.path.dirname(os.path.realpath(__file__)) ROCM_DIR = os.path.dirname(ROCPROFV3_AVAIL_DIR) ROCPROF_LIST_AVAIL_TOOL_LIBRARY = ( @@ -468,8 +471,6 @@ def main(argv=None): "ROCPROF_LIST_AVAIL_TOOL_LIBRARY", ROCPROF_LIST_AVAIL_TOOL_LIBRARY ) args = parse_arguments(argv) - if argv is None or len(argv) == 0: - avail.fatal_error("No arguments provided") if args.command: args.func(args) From 5b775a010fa3e7fbb72ba82d646e76afbdd21fb8 Mon Sep 17 00:00:00 2001 From: gobhardw Date: Tue, 5 Aug 2025 14:34:36 +0530 Subject: [PATCH 3/4] formatting --- projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py b/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py index e5770e691d5..a88f9853235 100755 --- a/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py +++ b/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py @@ -460,7 +460,7 @@ def process_qualifiers(pmc): def main(argv=None): if argv is None or len(argv) == 0: avail.fatal_error("No arguments provided") - + ROCPROFV3_AVAIL_DIR = os.path.dirname(os.path.realpath(__file__)) ROCM_DIR = os.path.dirname(ROCPROFV3_AVAIL_DIR) ROCPROF_LIST_AVAIL_TOOL_LIBRARY = ( From 063991ac78206b9dd22badc866d495ac33adfdba Mon Sep 17 00:00:00 2001 From: bgopesh Date: Mon, 1 Sep 2025 18:31:57 +0530 Subject: [PATCH 4/4] rocprofv3 and rocprofv3-avail to display help when no args are provided --- projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py | 6 ++++-- projects/rocprofiler-sdk/source/bin/rocprofv3.py | 5 +++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py b/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py index a88f9853235..9e3da6694d3 100755 --- a/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py +++ b/projects/rocprofiler-sdk/source/bin/rocprofv3-avail.py @@ -458,8 +458,10 @@ def process_qualifiers(pmc): def main(argv=None): - if argv is None or len(argv) == 0: - avail.fatal_error("No arguments provided") + # If no arguments provided, show help and exit + if (argv is None and len(sys.argv) == 1) or (argv is not None and len(argv) == 0): + parse_arguments(["--help"]) + return 0 ROCPROFV3_AVAIL_DIR = os.path.dirname(os.path.realpath(__file__)) ROCM_DIR = os.path.dirname(ROCPROFV3_AVAIL_DIR) diff --git a/projects/rocprofiler-sdk/source/bin/rocprofv3.py b/projects/rocprofiler-sdk/source/bin/rocprofv3.py index 0cb7fecacf8..9aec5fb7753 100755 --- a/projects/rocprofiler-sdk/source/bin/rocprofv3.py +++ b/projects/rocprofiler-sdk/source/bin/rocprofv3.py @@ -1662,6 +1662,11 @@ def main(argv=None): print(f" {key:>16}: {itr}") return 0 + # If no arguments provided, show help and exit + if (argv is None and len(sys.argv) == 1) or (argv is not None and len(argv) == 0): + parse_arguments(["--help"]) + return 0 + inp_args = ( parse_input(cmd_args.input) if getattr(cmd_args, "input") else [dotdict({})] )