Skip to content

Commit 0827fcd

Browse files
skc7assistant-librarian[bot]
authored andcommitted
[rocm-libraries] ROCm/rocm-libraries#11203 (commit 95f8050)
fix(hiptensor): drop -amdgpu-early-inline-all/-amdgpu-function-calls flags from cmake to fix OOM (#11203) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Motivation Enabling `AlwaysInlinerPass` in ROCm llvm-project and with below compiler flags enabled in CK, hiptensor and other libraries is causing build hang. - `-mllvm -amdgpu-early-inline-all=true` - `-mllvm -amdgpu-function-calls=false` This PR removes these flags from CMAKE so hiptensor builds rely on default inlining, fixing the OOM. JIRA ID : LCOMPILER-2589 ## Technical Details Removes the ROCm 6.2+ (`hip_VERSION_FLAT > 600241132`, non-Windows) block in `projects/hiptensor/CMakeLists.txt` that added: - `-amdgpu-early-inline-all=true` — marks essentially all functions for early inlining. - `-amdgpu-function-calls=false` — disables real device function calls, forcing everything to be inlined. ## Test Plan ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
1 parent 265a506 commit 0827fcd

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Full documentation for hipTensor is available at [rocm.docs.amd.com/projects/hip
1616

1717
### Resolved issues
1818
* Enabled `-frtti` on Windows to fix RTTI-related build failures.
19+
* Removed the internal compiler flags `-amdgpu-early-inline-all=true` and `-amdgpu-function-calls=false` from the build, which caused excessive compile-time memory usage (OOM) with newer ROCm/LLVM toolchains (JIRA: LCOMPILER-2589).
1920

2021
## hipTensor 2.3.0 for ROCm 7.14
2122

CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,6 @@ if(NOT WIN32 AND ${hip_VERSION_FLAT} GREATER 600140090)
202202
message(STATUS "Adding the enable-post-misched=0 compiler flag")
203203
add_compile_options("SHELL: -mllvm -enable-post-misched=0")
204204
endif()
205-
if(NOT WIN32 AND ${hip_VERSION_FLAT} GREATER 600241132)
206-
message(STATUS "Adding -amdgpu-early-inline-all=true and -amdgpu-function-calls=false")
207-
add_compile_options("SHELL: -mllvm -amdgpu-early-inline-all=true")
208-
add_compile_options("SHELL: -mllvm -amdgpu-function-calls=false")
209-
endif()
210205

211206
if(HIPTENSOR_CODE_COVERAGE)
212207
add_compile_options(-fprofile-instr-generate -fcoverage-mapping)

0 commit comments

Comments
 (0)