Merge branch 'fix/marketplace-review-round2': settings search, release attestations, 1.13 deprecations

Author: luoxuanzao

.github/workflows/release.yml

@@ -12,6 +12,9 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: write
+      # Required by attest-build-provenance to sign and store attestations.
+      id-token: write
+      attestations: write
 
     steps:
       - name: Checkout code
@@ -44,6 +47,16 @@ jobs:
       - name: Validate release artifacts
         run: npm run release:check
 
+      # Provenance lets users cryptographically verify the assets were built
+      # from this repository by this workflow (gh attestation verify).
+      - name: Attest build provenance
+        uses: actions/attest-build-provenance@0f67c3f4856b2e3261c31976d6725780e5e4c373 # v4.1.1
+        with:
+          subject-path: |
+            main.js
+            manifest.json
+            styles.css
+
       # Release notes come from the curated CHANGELOG.md section, not from
       # commit messages. A missing section means [Unreleased] was not renamed
       # before tagging, so fail instead of shipping empty notes.

package-lock.json

@@ -46,7 +46,7 @@
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "jest": "^30.3.0",
     "jest-environment-jsdom": "^30.3.0",
-    "obsidian": "latest",
+    "obsidian": "^1.13.1",
     "ts-jest": "^29.4.9",
     "typescript": "^6.0.2"
   },

package.json

@@ -1,4 +1,4 @@
-import type { App } from 'obsidian';
+import type { App, SettingDefinitionItem } from 'obsidian';
 import { Notice, PluginSettingTab, Setting } from 'obsidian';
 
 import type { ChatViewPlacement } from '../../core/types/settings';
@@ -20,6 +20,111 @@ export class QoderianSettingTab extends PluginSettingTab {
     this.plugin = plugin;
   }
 
+  /**
+   * Declarative mirror of display() for Obsidian's settings search (1.13+).
+   * Rendering stays imperative in display(); these definitions only feed the
+   * search index, so every entry is a plain name/desc row grouped under the
+   * same headings the page shows.
+   */
+  getSettingDefinitions(): SettingDefinitionItem[] {
+    setLocale(this.plugin.settings.locale as Locale);
+
+    return [
+      {
+        type: 'group',
+        heading: t('settings.setup'),
+        items: [
+          { name: t('settings.cliPath.name'), desc: t('settings.cliPath.desc') },
+        ],
+      },
+      { name: t('settings.language.name'), desc: t('settings.language.desc') },
+      {
+        type: 'group',
+        heading: t('settings.display'),
+        items: [
+          { name: t('settings.maxTabs.name'), desc: t('settings.maxTabs.desc') },
+          { name: t('settings.chatViewPlacement.name'), desc: t('settings.chatViewPlacement.desc') },
+          { name: t('settings.enableAutoScroll.name'), desc: t('settings.enableAutoScroll.desc') },
+          { name: t('settings.deferMathRenderingDuringStreaming.name'), desc: t('settings.deferMathRenderingDuringStreaming.desc') },
+          { name: t('settings.expandFileEditsByDefault.name'), desc: t('settings.expandFileEditsByDefault.desc') },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.conversations'),
+        items: [
+          { name: t('settings.autoTitle.name'), desc: t('settings.autoTitle.desc') },
+          {
+            name: t('settings.titleModel.name'),
+            desc: t('settings.titleModel.desc'),
+            visible: () => this.plugin.settings.enableAutoTitleGeneration,
+          },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.content'),
+        items: [
+          { name: t('settings.userName.name'), desc: t('settings.userName.desc') },
+          { name: t('settings.systemPrompt.name'), desc: t('settings.systemPrompt.desc') },
+          { name: t('settings.excludedTags.name'), desc: t('settings.excludedTags.desc') },
+          { name: t('settings.mediaFolder.name'), desc: t('settings.mediaFolder.desc') },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.input'),
+        items: [
+          { name: t('settings.requireCommandOrControlEnterToSend.name'), desc: t('settings.requireCommandOrControlEnterToSend.desc') },
+          { name: t('settings.navMappings.name'), desc: t('settings.navMappings.desc') },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.safety'),
+        items: [
+          { name: t('settings.loadUserSettings.name'), desc: t('settings.loadUserSettings.desc') },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.slashCommands.name'),
+        items: [
+          { name: t('settings.slashCommands.commands'), desc: t('settings.slashCommands.commandsDesc') },
+          { name: t('settings.slashCommands.skills'), desc: t('settings.slashCommands.skillsDesc') },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.subagents.name'),
+        items: [
+          { name: t('settings.subagents.name'), desc: t('settings.subagents.desc') },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.mcpServers.name'),
+        items: [
+          { name: t('settings.mcpServers.name'), desc: t('settings.mcpServers.desc') },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.plugins.name'),
+        items: [
+          { name: t('settings.plugins.name'), desc: t('settings.plugins.desc') },
+        ],
+      },
+      {
+        type: 'group',
+        heading: t('settings.experimental'),
+        items: [
+          { name: t('settings.enableBangBash.name'), desc: t('settings.enableBangBash.desc') },
+        ],
+      },
+    ];
+  }
+
   display(): void {
     const { containerEl } = this;
     containerEl.empty();
@@ -97,7 +202,6 @@ export class QoderianSettingTab extends PluginSettingTab {
       slider
         .setLimits(3, 10, 1)
         .setValue(this.plugin.settings.maxTabs ?? 3)
-        .setDynamicTooltip()
         .onChange(async (value) => {
           this.plugin.settings.maxTabs = value;
           await this.plugin.saveSettings();

src/features/settings/settings-tab.ts

@@ -1,4 +1,4 @@
-import { type App,Modal, Setting } from 'obsidian';
+import { type App,Modal, requireApiVersion, Setting } from 'obsidian';
 
 import { t } from '../../i18n/i18n';
 
@@ -39,16 +39,23 @@ class ConfirmModal extends Modal {
           .setButtonText(t('common.cancel'))
           .onClick(() => this.close())
       )
-      .addButton(btn =>
+      .addButton(btn => {
         btn
           .setButtonText(this.confirmText)
-          .setWarning()
           .onClick(() => {
             this.resolved = true;
             this.resolve(true);
             this.close();
-          })
-      );
+          });
+        // setDestructive replaced setWarning in 1.13. On older installs
+        // covered by minAppVersion, apply the class the deprecated
+        // setWarning() used to add instead of calling the API.
+        if (requireApiVersion('1.13.0')) {
+          btn.setDestructive();
+        } else {
+          btn.buttonEl.addClass('mod-warning');
+        }
+      });
   }
 
   onClose() {

src/shared/modals/confirm-modal.ts

@@ -263,6 +263,10 @@ export const MarkdownRenderer = {
 
 export const setIcon = jest.fn();
 
+// Tests run against the newest API surface, so version gates take the
+// modern branch by default.
+export const requireApiVersion = jest.fn(() => true);
+
 export const addIcon = jest.fn();
 
 // Notice mock that tracks constructor calls

tests/__mocks__/obsidian.ts

@@ -46,6 +46,7 @@ jest.mock('obsidian', () => {
         _onClick: null as null | (() => void),
         setButtonText: jest.fn().mockReturnThis(),
         setWarning: jest.fn().mockReturnThis(),
+        setDestructive: jest.fn().mockReturnThis(),
         onClick: jest.fn((handler: () => void) => {
           btn._onClick = handler;
           return btn;