fix(mobile): break signal report summary sections onto separate lines (port #2317)#2543
Open
Gilbert09 wants to merge 1 commit into
Open
fix(mobile): break signal report summary sections onto separate lines (port #2317)#2543Gilbert09 wants to merge 1 commit into
Gilbert09 wants to merge 1 commit into
Conversation
… (port #2317) Agent-generated signal report summaries often pack the labelled sections (**What's happening:**, **Root cause:**, **How to resolve:**) onto a single line. Run the summary markdown through a new formatSignalReportSummaryMarkdown util before rendering it via MarkdownText, so each section header and its body land on their own line. Applied in the report detail screen and the expanded Tinder card. Ports the desktop change in #2317. Generated-By: PostHog Code Task-Id: 73013ebe-bbe1-49b3-8739-1cf570a37c9d
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(mobile): break signal report summary..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #2317 to the mobile app.
Problem
Agent-generated signal report summaries often pack the labelled sections onto a single line, e.g.:
which renders as one run-on paragraph in
MarkdownText.Change
formatSignalReportSummaryMarkdowntoapps/mobile/src/features/inbox/utils.ts. It inserts blank lines before each bold section header (**What's happening:**,**Root cause:**,**How to resolve:**) and after the header label, so each section and its body render on their own line. Matching is case-insensitive.MarkdownTextin both render sites:apps/mobile/src/app/inbox/[...id].tsx)TinderView.tsxPure presentation formatting in the renderer layer — no main-process or business-logic changes.
Testing
pnpm --filter mobile test— 202 passedpnpm --filter mobile lint— clean