Skip to content

chore(code): Upgrade Electron 42, Vite 8, React 19.2 and deps#2512

Open
charlesvien wants to merge 9 commits into
mainfrom
06-06-package_updates
Open

chore(code): Upgrade Electron 42, Vite 8, React 19.2 and deps#2512
charlesvien wants to merge 9 commits into
mainfrom
06-06-package_updates

Conversation

@charlesvien

@charlesvien charlesvien commented Jun 6, 2026

Copy link
Copy Markdown
Member

Problem

We've fallen several majors behind (Electron 41, Vite 6), missing performance, security and bug fixes.

Changes

  1. Upgrade Electron 41 → 42.3.0 (+ Forge 7.11.2, @electron/rebuild 4.0.4)
  2. Override node-abi and patch better-sqlite3 for Electron 42's V8 sandbox ABI
  3. Upgrade Vite 6 → 8 (Rolldown bundler) with plugin-react 6
  4. Upgrade React 19.1 → 19.2, unified across code + mobile; dedupe zod 4.x
  5. Bump TanStack, tRPC, Tiptap, Tailwind 4.3, vitest, playwright, storybook, turbo

How did you test this?

Manually

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

charlesvien commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

@charlesvien charlesvien changed the title package updates feat: Upgrade Electron 42, Vite 8, React 19.2 and deps Jun 6, 2026
@charlesvien charlesvien changed the title feat: Upgrade Electron 42, Vite 8, React 19.2 and deps chore(code): Upgrade Electron 42, Vite 8, React 19.2 and deps Jun 6, 2026
@charlesvien charlesvien marked this pull request as ready for review June 6, 2026 22:17
@greptile-apps

greptile-apps Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

T-Rex T-Rex Logs

What T-Rex did

  • Verified the Electron 42 upgrade by inspecting the lockfile resolution, confirming node-abi resolves to 3.92.0 and better-sqlite3@12.10.0 is installed with the declared patch hash.
  • Validated Forge Vite plugin configuration still uses the expected build and renderer entries.
  • Confirmed React is resolved through the workspace override.
  • Ran the full dependency and configuration validation script to review node-abi, better-sqlite3 patch application, V8 compatibility patches, Vite peer dependency compatibility, and Forge config structure.
  • Validated that the patch file patches 3 files with kExternalPointerTypeTagDefault for V8 14.6+ compatibility.
  • Verified forge.config.ts uses VitePlugin with the correct build/renderer config structure, and confirmed all three vite config files exist.
  • Identified a mismatch in vitest peer dependencies: @vitest/coverage-v8 requires vitest in the 0.32–1 range, but vitest resolves to 2.x, indicating a major version mismatch.
  • Noted that no node_modules are installed in the sandbox, so actual builds/tests could not be run, though lockfile and registry metadata analysis are conclusive.
Artifacts

Dependency upgrade validation log

  • Helps inspect the lockfile resolution and installed versions for the Electron 42 upgrade.

Generated validation script

  • Contains the script used to reproduce the dependency validation checks.

Full validation script output checking node-abi, better-sqlite3 patch, Vite versions, forge config, and dependency compatibility

  • The consolidated output from the validation script used to review dependencies and configurations.

Details of @vitest/coverage-v8 peer dependency mismatch with vitest 2.x

  • Notes on the version mismatch between vitest-related packages.

Validation script invocation details

  • Shell script content used to run the validation checks.

T-Rex Ran code and verified through T-Rex

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/electron-trpc/package.json:35
**Update coverage provider**

`test:ci` runs Vitest with `--coverage`, but this package still installs `@vitest/coverage-v8@^0.34.0` while Vitest resolves to 2.x. The lockfile shows that coverage provider declares a peer range of `vitest >=0.32.0 <1`, so coverage runs for `@posthog/electron-trpc` can fail or run against an unsupported provider. Please bump `@vitest/coverage-v8` to the matching Vitest major.

Reviews (1): Last reviewed commit: "upgrade vite to 8 (rolldown)" | Re-trigger Greptile

Comment thread packages/electron-trpc/package.json Outdated

@k11kirky k11kirky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking your merge. looks safe, just want to trim comments and test further

@charlesvien charlesvien force-pushed the 06-06-retry_binary_downloads_on_transient_http_errors branch from eda4c7c to 89dfb6d Compare June 9, 2026 01:37
@charlesvien charlesvien force-pushed the 06-06-package_updates branch from c505ae8 to 978596d Compare June 9, 2026 01:37
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit f71d76f.

Base automatically changed from 06-06-retry_binary_downloads_on_transient_http_errors to main June 9, 2026 01:45
@charlesvien charlesvien force-pushed the 06-06-package_updates branch from 978596d to f71d76f Compare June 9, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants