Skip to content

refactor: split electron app into several packages#2442

Open
jonathanlab wants to merge 9 commits into
mainfrom
05-30-refactor_everything
Open

refactor: split electron app into several packages#2442
jonathanlab wants to merge 9 commits into
mainfrom
05-30-refactor_everything

Conversation

@jonathanlab

@jonathanlab jonathanlab commented May 29, 2026

Copy link
Copy Markdown
Contributor

The app has grown large and unwieldy, and we need to split it up for several use cases (Web support, code sharing with mobile/web, sharing logic between cloud runs and local runs)

This PR has done two things:

  • Split apps/code into three packages: ui, core and workspace-server (and some additional plumbing packages such as workspace-client)
  • Move as much business logic away from ui into core, the aim was dumb stores and hooks. This has partially been achieved but could use more work in follow up PRs

I recommend reading AGENTS.md for a further break down on how the repository is structured and conventions we'll use from now on: https://github.com/PostHog/code/blob/ed9cd1282cb70a3023c524fca4562604611f3610/AGENTS.md

This also includes all commits since 50c6d9054 starting at 2026-05-29 , refactored for the new package structure. See UPSTREAM_REPLAY.md

jonathanlab commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jonathanlab jonathanlab force-pushed the 05-30-refactor_everything branch 7 times, most recently from ff0f9e6 to f657a58 Compare June 3, 2026 16:54
@jonathanlab jonathanlab changed the title refactor: everything cgcggvcg Jun 3, 2026
@jonathanlab jonathanlab changed the title cgcggvcg refactor: everything Jun 3, 2026
@jonathanlab jonathanlab force-pushed the 05-30-refactor_everything branch 7 times, most recently from 6fd1b4d to a64a1f1 Compare June 5, 2026 11:46
@jonathanlab jonathanlab changed the title refactor: everything refactor: split electron app into several packages Jun 5, 2026
@jonathanlab jonathanlab force-pushed the 05-30-refactor_everything branch 2 times, most recently from ed9cd12 to 50c3364 Compare June 8, 2026 14:19
@jonathanlab jonathanlab changed the base branch from 05-29-refactor_update_refactor_doc_and_fix_ci to graphite-base/2442 June 8, 2026 14:31
@jonathanlab jonathanlab force-pushed the graphite-base/2442 branch from d124743 to 61f39dd Compare June 8, 2026 14:31
@jonathanlab jonathanlab changed the base branch from graphite-base/2442 to main June 8, 2026 14:31
@jonathanlab jonathanlab marked this pull request as ready for review June 8, 2026 14:34
@jonathanlab jonathanlab force-pushed the 05-30-refactor_everything branch from 50c3364 to be21c7b Compare June 8, 2026 15:31
@jonathanlab jonathanlab force-pushed the 05-30-refactor_everything branch 4 times, most recently from 13b6a70 to 9feebfa Compare June 9, 2026 13:14
@jonathanlab jonathanlab force-pushed the 05-30-refactor_everything branch from 9feebfa to 4a8ceae Compare June 9, 2026 14:09

@k11kirky k11kirky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG - great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants