fix(patterns): resolve theme pattern directory from theme metadata

Theme Gutenberg patterns were never registered. PatternService built the
pattern directory from WP_Theme::get_theme_root(), which returns WordPress'
raw theme root and never passes through the `theme_root` filter Pollora
installs. On the default skeleton layout it resolved to
WP_CONTENT_DIR/themes instead of the configured theme.path, so the is_dir()
guard returned early and no pattern file was ever read — silently, with no
error or log entry.

The directory is now derived from ThemeMetadata, the authoritative source
for Pollora theme paths. Discovery also walks the full theme ancestry via
ThemeService::getParentThemes() (ancestors first, so the active theme can
override an inherited slug) instead of a single parent level, and the
WP_Theme instance used for TextDomain translation is built with an explicit
theme root.

Also removes PatternRegistrar, an unreferenced duplicate of PatternService
carrying the same bug via get_stylesheet_directory().

Backport of 01605ba onto the v13.4.x line.

Closes #295

Claude-Session: https://claude.ai/code/session_01Lsb47rNQPxRzFPUxCAkwxU

Author: ogorzalka

CHANGELOG.md

@@ -5,7 +5,26 @@ All notable changes to the Pollora framework will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased](https://github.com/Pollora/framework/compare/v13.4.0...develop)
+## [Unreleased](https://github.com/Pollora/framework/compare/v13.4.3...develop)
+
+## [v13.4.3](https://github.com/Pollora/framework/compare/v13.4.2...v13.4.3) - 2026-08-31
+
+### Fixed
+- Theme Gutenberg patterns are registered again ([#295](https://github.com/Pollora/framework/issues/295)) — `PatternService` resolved the pattern directory from `WP_Theme::get_theme_root()`, which bypasses the `theme_root` filter and pointed at `WP_CONTENT_DIR/themes` instead of the configured `theme.path`; the directory is now derived from `ThemeMetadata`
+- Patterns are discovered across the full theme ancestry (ancestors first, so the active theme can override an inherited slug) instead of a single parent level
+
+### Removed
+- `Pollora\BlockPattern\Infrastructure\Registrars\PatternRegistrar` — dead duplicate of `PatternService` carrying the same theme-root resolution bug
+
+## [v13.4.2](https://github.com/Pollora/framework/compare/v13.4.1...v13.4.2) - 2026-06-29
+
+### Fixed
+- Force `$_SERVER['HTTPS']` when `APP_URL` uses HTTPS scheme
+
+## [v13.4.1](https://github.com/Pollora/framework/compare/v13.4.0...v13.4.1) - 2026-06-29
+
+### Fixed
+- Use `config('app.url')` for `WP_HOME`/`WP_SITEURL` instead of `url()` helper
 
 ## [v13.4.0](https://github.com/Pollora/framework/compare/v13.3.0...v13.4.0) - 2026-04-22
 

src/BlockPattern/Application/Services/PatternService.php

@@ -12,6 +12,7 @@
 use Pollora\BlockPattern\Domain\Support\PatternConstants;
 use Pollora\Config\Domain\Contracts\ConfigRepositoryInterface;
 use Pollora\Theme\Domain\Contracts\ThemeService;
+use Pollora\Theme\Domain\Models\ThemeMetadata;
 
 /**
  * Application service for pattern use cases.
@@ -84,24 +85,18 @@ private function registerCategories(): void
      */
     private function registerPatterns(): void
     {
-        if (! function_exists('wp_get_theme')) {
-            return;
-        }
-
         $theme = $this->themeService->theme();
 
-        if (! function_exists('get_stylesheet_directory') || ! $theme) {
+        if (! $theme instanceof ThemeMetadata) {
             return;
         }
 
-        $parentTheme = $theme->getParentTheme();
-
-        if ($parentTheme) {
-            $this->registerPattern($parentTheme);
+        // Ancestors first, so the active theme can override an inherited pattern slug.
+        foreach (array_reverse($this->themeService->getParentThemes()) as $parentTheme) {
+            $this->registerPatternsFromTheme($parentTheme);
         }
 
-        $this->registerPattern($theme->getName());
-
+        $this->registerPatternsFromTheme($theme);
     }
 
     /**
@@ -111,26 +106,77 @@ private function registerPatterns(): void
      * directory, following the established directory structure.
      *
      * @param  string  $themeName  Name of the theme to process
-     *
-     * @throws \RuntimeException If WordPress functions are not available
      */
     public function registerPattern(string $themeName): void
     {
-        if (! function_exists('wp_get_theme')) {
-            return;
-        }
+        $theme = $this->resolveTheme($themeName);
 
-        $theme = wp_get_theme($themeName);
-        $themeRoot = $theme->get_theme_root();
+        if ($theme instanceof ThemeMetadata) {
+            $this->registerPatternsFromTheme($theme);
+        }
+    }
 
-        $patternDir = $themeRoot.DIRECTORY_SEPARATOR.$themeName.PatternConstants::PATTERN_DIRECTORY;
+    /**
+     * Register every pattern shipped by the given theme.
+     *
+     * The pattern directory is resolved from the theme metadata rather than from
+     * WordPress: `WP_Theme::get_theme_root()` returns the raw theme root and never
+     * goes through the `theme_root` filter Pollora installs, so it points at
+     * `WP_CONTENT_DIR/themes` instead of the configured `theme.path`.
+     */
+    private function registerPatternsFromTheme(ThemeMetadata $theme): void
+    {
+        $patternDir = $theme->getBasePath().PatternConstants::PATTERN_DIRECTORY;
 
         // Skip if directory doesn't exist
         if (! is_dir($patternDir)) {
             return;
         }
 
-        $this->registerPatternsFromDirectory($patternDir, $theme);
+        $this->registerPatternsFromDirectory($patternDir, $this->wordPressTheme($theme));
+    }
+
+    /**
+     * Find the metadata of a theme by name within the active theme hierarchy.
+     *
+     * Falls back to a metadata instance built from the active theme's root for
+     * themes that are not part of the current hierarchy.
+     */
+    private function resolveTheme(string $themeName): ?ThemeMetadata
+    {
+        $activeTheme = $this->themeService->theme();
+
+        $hierarchy = $activeTheme instanceof ThemeMetadata
+            ? [$activeTheme, ...$this->themeService->getParentThemes()]
+            : $this->themeService->getParentThemes();
+
+        foreach ($hierarchy as $theme) {
+            if ($theme->getName() === $themeName) {
+                return $theme;
+            }
+        }
+
+        if (! $activeTheme instanceof ThemeMetadata) {
+            return null;
+        }
+
+        return new ThemeMetadata($themeName, dirname($activeTheme->getBasePath()));
+    }
+
+    /**
+     * Get the WordPress theme instance backing a theme, for metadata translation.
+     *
+     * The theme root is passed explicitly so WordPress resolves the theme from
+     * Pollora's theme path instead of its own default one. Returns the metadata
+     * itself when WordPress is unavailable; the extractor then skips translation.
+     */
+    private function wordPressTheme(ThemeMetadata $theme): object
+    {
+        if (! function_exists('wp_get_theme')) {
+            return $theme;
+        }
+
+        return \wp_get_theme($theme->getName(), dirname($theme->getBasePath()));
     }
 
     /**

src/BlockPattern/Infrastructure/Registrars/PatternRegistrar.php

@@ -245,6 +245,9 @@ public function theme(): ?ThemeMetadata
         return $this->theme;
     }
 
+    /**
+     * @return array<int, ThemeMetadata>
+     */
     public function getParentThemes(): array
     {
         return $this->parentThemes;

src/Theme/Application/Services/ThemeManager.php

@@ -43,7 +43,9 @@ public function theme(): ?ThemeMetadata;
     public function parent(): ?string;
 
     /**
-     * Get all parent themes
+     * Get all parent themes, closest ancestor first
+     *
+     * @return array<int, ThemeMetadata>
      */
     public function getParentThemes(): array;