Testing the same methods/properties are not diagnosed on other classes

Author: jpalac

src/NServiceBus.AzureFunctions.Analyzer.Tests/AzureFunctionsConfigurationAnalyzerTests.cs

@@ -1,5 +1,7 @@
 namespace NServiceBus.AzureFunctions.Analyzer.Tests
 {
+    using System.Threading;
+    using System;
     using System.Threading.Tasks;
     using NUnit.Framework;
     using static AzureFunctionsDiagnostics;
@@ -33,5 +35,42 @@ void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
 
             return Assert(diagnosticId, source);
         }
+
+        [TestCase("DefineCriticalErrorAction((errorContext, cancellationToken) => Task.CompletedTask)", DefineCriticalErrorActionNotAllowedId)]
+        [TestCase("LimitMessageProcessingConcurrencyTo(5)", LimitMessageProcessingToNotAllowedId)]
+        [TestCase("MakeInstanceUniquelyAddressable(null)", MakeInstanceUniquelyAddressableNotAllowedId)]
+        [TestCase("OverrideLocalAddress(null)", OverrideLocalAddressNotAllowedId)]
+        [TestCase("PurgeOnStartup(true)", PurgeOnStartupNotAllowedId)]
+        [TestCase("SetDiagnosticsPath(null)", SetDiagnosticsPathNotAllowedId)]
+        [TestCase("UseTransport(new AzureServiceBusTransport(null))", UseTransportNotAllowedId)]
+        public Task DiagnosticIsNotReportedForOtherEndpointConfiguration(string configuration, string diagnosticId)
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading;
+using System.Threading.Tasks; 
+
+class SomeOtherClass
+{{
+    internal void DefineCriticalErrorAction(Func<ICriticalErrorContext, CancellationToken, Task> onCriticalError) {{ }}
+    internal void LimitMessageProcessingConcurrencyTo(int Number) {{ }}
+    internal void MakeInstanceUniquelyAddressable(string someProperty) {{ }}
+    internal void OverrideLocalAddress(string someProperty) {{ }}
+    internal void PurgeOnStartup(bool purge) {{ }}
+    internal void SetDiagnosticsPath(string someProperty) {{ }}
+    internal void UseTransport(AzureServiceBusTransport transport) {{ }}
+}}
+
+class Foo
+{{
+    void Bar(SomeOtherClass endpointConfig)
+    {{
+        endpointConfig.{configuration};
+    }}
+}}";
+
+            return Assert(diagnosticId, source);
+        }
     }
 }

src/NServiceBus.AzureFunctions.Analyzer.Tests/AzureFunctionsSendReplyOptionsAnalyzerTests.cs

@@ -26,5 +26,34 @@ void Bar({optionsType} options)
 
             return Assert(diagnosticId, source);
         }
+
+
+        [TestCase("SomeOtherClass", "RouteReplyToAnyInstance", RouteReplyToAnyInstanceNotAllowedId)]
+        [TestCase("SomeOtherClass", "RouteReplyToThisInstance", RouteReplyToThisInstanceNotAllowedId)]
+        [TestCase("SomeOtherClass", "RouteToThisInstance", RouteToThisInstanceNotAllowedId)]
+        public Task DiagnosticIsNotReportedForOtherOptions(string optionsType, string method, string diagnosticId)
+        {
+            var source =
+                $@"using NServiceBus;
+using System;
+using System.Threading.Tasks;
+
+class SomeOtherClass
+{{
+    internal void RouteReplyToAnyInstance() {{ }}
+    internal void RouteReplyToThisInstance() {{ }}
+    internal void RouteToThisInstance() {{ }}
+}}
+
+class Foo
+{{
+    void Bar({optionsType} options)
+    {{
+        options.{method}();
+    }}
+}}";
+
+            return Assert(diagnosticId, source);
+        }
     }
 }

src/NServiceBus.AzureFunctions.Analyzer.Tests/AzureFunctionsTransportAnalyzerTests.cs

@@ -36,5 +36,37 @@ void Extension(TransportExtensions<AzureServiceBusTransport> transportExtension)
 
             return Assert(diagnosticId, source);
         }
+
+        [TestCase("EntityMaximumSize", "5", EntityMaximumSizeNotAllowedId)]
+        [TestCase("MaxAutoLockRenewalDuration", "new System.TimeSpan(0, 0, 5, 0)", MaxAutoLockRenewalDurationNotAllowedId)]
+        [TestCase("PrefetchCount", "5", PrefetchCountNotAllowedId)]
+        [TestCase("PrefetchMultiplier", "5", PrefetchMultiplierNotAllowedId)]
+        [TestCase("TimeToWaitBeforeTriggeringCircuitBreaker", "new System.TimeSpan(0, 0, 5, 0)", TimeToWaitBeforeTriggeringCircuitBreakerNotAllowedId)]
+        public Task DiagnosticIsNotReportedForNonTransportConfiguration(string configName, string configValue, string diagnosticId)
+        {
+            var source =
+                $@"using NServiceBus;
+using System;
+using System.Threading.Tasks;
+
+class SomeOtherClass
+{{
+    internal int EntityMaximumSize {{ get; set; }}
+    internal TimeSpan MaxAutoLockRenewalDuration {{ get; set; }}
+    internal int PrefetchCount {{ get; set; }}
+    internal int PrefetchMultiplier {{ get; set; }}
+    internal TimeSpan TimeToWaitBeforeTriggeringCircuitBreaker {{ get; set; }}
+}}
+
+class Foo
+{{
+    void Direct(SomeOtherClass endpointConfig)
+    {{
+        endpointConfig.{configName} = {configValue};
+    }}
+}}";
+
+            return Assert(diagnosticId, source);
+        }
     }
 }