WIP: TASK Fix enum member access on instance

Author: mhsdesign

src/TypeSystem/Resolver/Access/AccessTypeResolver.php

@@ -28,7 +28,6 @@
 use PackageFactory\ComponentEngine\TypeSystem\ScopeInterface;
 use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumMemberType;
 use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumStaticType;
-use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumType;
 use PackageFactory\ComponentEngine\TypeSystem\Type\StructType\StructType;
 use PackageFactory\ComponentEngine\TypeSystem\TypeInterface;
 use PackageFactory\ComponentEngine\Definition\AccessType;
@@ -46,13 +45,13 @@ public function resolveTypeOf(AccessNode $accessNode): TypeInterface
         $rootType = $expressionResolver->resolveTypeOf($accessNode->root);
 
         return match ($rootType::class) {
-            EnumType::class, EnumStaticType::class => $this->createEnumMemberType($accessNode, $rootType),
+            EnumStaticType::class => $this->createEnumMemberType($accessNode, $rootType),
             StructType::class => throw new \Exception('@TODO: StructType Access is not implemented'),
             default => throw new \Exception('@TODO Error: Cannot access on type ' . $rootType::class)
         };
     }
 
-    private function createEnumMemberType(AccessNode $accessNode, EnumType|EnumStaticType $enumType): EnumMemberType
+    private function createEnumMemberType(AccessNode $accessNode, EnumStaticType $enumType): EnumMemberType
     {
         if (!(
             count($accessNode->chain->items) === 1

src/TypeSystem/Type/EnumType/EnumMemberType.php

@@ -29,12 +29,12 @@ final class EnumMemberType implements TypeInterface
     public function __construct(
         public readonly EnumType|EnumStaticType $enumType,
         public readonly string $memberName,
-        public readonly ?TypeInterface $memberValueType
+        public readonly ?TypeInterface $memberBackedValueType
     ) {
     }
 
     public function is(TypeInterface $other): bool
     {
-        return $this->memberValueType?->is($other) ?? false;
+        return $this->memberBackedValueType?->is($other) ?? false;
     }
 }

test/Unit/TypeSystem/Resolver/Access/AccessTypeResolverTest.php

@@ -47,6 +47,11 @@ public function invalidAccessExamples(): iterable
             'SomeEnum.NonExistent',
             '@TODO cannot access member NonExistent of enum SomeEnum'
         ];
+
+        yield "access enum member on non static enum instance" => [
+            'someEnumValue.A',
+            "@TODO Error: Cannot access on type PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumType"
+        ];
     }
 
     private function resolveAccessType(string $accessAsString, ScopeInterface $scope): TypeInterface
@@ -85,7 +90,7 @@ public function access(): void
 
         $this->assertEquals("A", $accessType->memberName);
 
-        $this->assertTrue($accessType->memberValueType->is(StringType::get()));
+        $this->assertTrue($accessType->memberBackedValueType?->is(StringType::get()));
     }
 
     /**
@@ -103,7 +108,8 @@ public function invalidAccessResultsInError(string $accessAsString, string $expe
         );
         $scope = new DummyScope([
             'someString' => StringType::get(),
-            'SomeEnum' => $someEnum
+            'SomeEnum' => $someEnum,
+            'someEnumValue' => $someEnum->toEnumInstanceType()
         ]);
         $accessTypeResolver = new AccessTypeResolver(
             scope: $scope