TASK: Make $parentScope in ModuleScope constructor mandatory

Author: grebaldi

src/TypeSystem/Scope/ModuleScope/ModuleScope.php

@@ -33,13 +33,13 @@ final class ModuleScope implements ScopeInterface
     public function __construct(
         private readonly LoaderInterface $loader,
         private readonly ModuleNode $moduleNode,
-        private readonly ?ScopeInterface $parentScope
+        private readonly ScopeInterface $parentScope
     ) {
     }
 
     public function lookupTypeFor(string $name): ?TypeInterface
     {
-        return $this->parentScope?->lookupTypeFor($name) ?? null;
+        return $this->parentScope->lookupTypeFor($name);
     }
 
     public function resolveTypeReference(TypeReferenceNode $typeReferenceNode): TypeInterface
@@ -48,10 +48,6 @@ public function resolveTypeReference(TypeReferenceNode $typeReferenceNode): Type
             return $this->loader->resolveTypeOfImport($importNode);
         }
 
-        if ($this->parentScope) {
-            return $this->parentScope->resolveTypeReference($typeReferenceNode);
-        }
-
-        throw new \Exception('@TODO: Unknown Type ' . $typeReferenceNode->name);
+        return $this->parentScope->resolveTypeReference($typeReferenceNode);
     }
 }

test/Unit/TypeSystem/Scope/ModuleScope/ModuleScopeTest.php

@@ -27,7 +27,6 @@
 use PackageFactory\ComponentEngine\Test\Unit\Module\Loader\Fixtures\DummyLoader;
 use PackageFactory\ComponentEngine\Test\Unit\TypeSystem\Scope\Fixtures\DummyScope;
 use PackageFactory\ComponentEngine\TypeSystem\Scope\ModuleScope\ModuleScope;
-use PackageFactory\ComponentEngine\TypeSystem\Scope\GlobalScope\GlobalScope;
 use PackageFactory\ComponentEngine\TypeSystem\TypeInterface;
 use PHPUnit\Framework\TestCase;
 
@@ -55,7 +54,7 @@ public function resolvesTypeReferencesForModuleImports(): void
                 ],
             ]),
             moduleNode: $moduleNode,
-            parentScope: null
+            parentScope: new DummyScope()
         );
 
         $this->assertSame(
@@ -100,4 +99,4 @@ public function fallsBackToParentScopeWhenProvidingTypesForValues(): void
             $moduleScope->lookupTypeFor('foo')
         );
     }
-}
+}