Skip to content

Commit 7ab0ff4

Browse files
committed
Use username as fallback for first/last, don't select frame on settings click
1 parent aeeb5e3 commit 7ab0ff4

4 files changed

Lines changed: 18 additions & 9 deletions

File tree

src/components/sidebar/SidebarComponent.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ class SidebarComponent extends Component {
4444
isSelected={frame.id == selectedFrameId} // TODO: === once we can ensure string ids
4545
isOwner={frame.ownerId === user.id}
4646
editFrameSettings={() => editFrameSettings(frame.id)}
47+
updateSidebarState={updateSidebarState}
4748
selectFrame={selectFrame}
4849
pathname={location.pathname} />
4950
)}

src/components/sidebar/SidebarFrameItemComponent.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,15 @@ class SidebarFrameItemComponent extends React.Component {
1717
selectFrame(frame.id);
1818
}
1919

20+
_editFrameSettings(e) {
21+
let { editFrameSettings, updateSidebarState } = this.props;
22+
e.stopPropagation();
23+
updateSidebarState(false);
24+
editFrameSettings();
25+
}
26+
2027
render() {
21-
let {isSelected, editFrameSettings, isOwner, frame} = this.props;
28+
let {isSelected, isOwner, frame} = this.props;
2229

2330
let className = 'sidebar-frame-item sidebar__row sidebar__row--frame';
2431
className += isSelected ? ' sidebar_row--frame-active' : '';
@@ -37,10 +44,10 @@ class SidebarFrameItemComponent extends React.Component {
3744
: ''
3845
}
3946
{ isOwner
40-
? <span className="sidebar-frame-item__settings" onClick={editFrameSettings}>
47+
? <span className="sidebar-frame-item__settings" onClick={::this._editFrameSettings}>
4148
<img className="icon-settings" src={settingsIcon} />
4249
</span>
43-
: <span className="sidebar-frame-item__settings" onClick={editFrameSettings}>
50+
: <span className="sidebar-frame-item__settings" onClick={::this._editFrameSettings}>
4451
<img className="icon-settings" src={settingsIcon} />
4552
</span>
4653
}

src/components/user/EditProfileFormComponent.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,12 @@ class EditProfileFormComponent extends React.Component {
9797
<div className="form-group">
9898
<button href="#" className="btn btn-default btn-fw">{ _submitText }</button>
9999
</div>
100-
{ currentUser
101-
&&
102-
<div className="form-group">
103-
<button className="btn btn-destructive btn-fw" onClick={::this._handleDeleteClick}>Delete Account</button>
104-
</div>
100+
{
101+
// currentUser
102+
// &&
103+
// <div className="form-group">
104+
// <button className="btn btn-destructive btn-fw" onClick={::this._handleDeleteClick}>Delete Account</button>
105+
// </div>
105106
}
106107
</form>
107108
);

src/components/user/ProfileHeaderComponent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class ProfileHeaderComponent extends React.Component {
1616

1717
return (
1818
<div className="profile-header">
19-
<div className="profile-header__name">{user.full_name}</div>
19+
<div className="profile-header__name">{user.full_name || user.username}</div>
2020
{ user.website || user.twitter
2121
? <div className="profile-header__social">
2222
{ user.website

0 commit comments

Comments
 (0)