Recognize custom registered family authorities

Treat custom AutoRegisterMeta-derived metaclasses and nominal Registered family bases as satisfying semantic inheritance membership SSOT. Add a regression test for derived registered family roots so the advisor does not push duplicate registry declarations when a shared nominal base already owns registration semantics.

Author: trissim

nominal_refactor_advisor/detectors/_helpers.py

@@ -617,7 +617,15 @@ def declaration_scaffold(
     def declares_autoregister_meta(self, node: ast.ClassDef) -> bool:
         return any(
             (
-                _ast_terminal_name(keyword.value) == "AutoRegisterMeta"
+                (metaclass_name := _ast_terminal_name(keyword.value)) is not None
+                and (
+                    metaclass_name == "AutoRegisterMeta"
+                    or metaclass_name.endswith("AutoRegisterMeta")
+                    or (
+                        "Registered" in metaclass_name
+                        and metaclass_name.endswith("Meta")
+                    )
+                )
                 for keyword in node.keywords
                 if keyword.arg == "metaclass"
             )
@@ -629,8 +637,7 @@ def inherits_named_registration_authority(self, node: ast.ClassDef) -> bool:
                 (base_name := _ast_terminal_name(base)) is not None
                 and (
                     "AutoRegister" in base_name
-                    or base_name.startswith("Registered")
-                    or base_name.endswith("Registered")
+                    or "Registered" in base_name
                 )
                 for base in node.bases
             )

tests/test_refactor_advisor.py

@@ -5733,6 +5733,20 @@ def test_ignores_semantic_inheritance_family_with_inherited_registry_authority(
     )
 
 
+def test_ignores_semantic_inheritance_family_with_custom_registered_family_base(
+    tmp_path: Path,
+) -> None:
+    _write_module(
+        tmp_path,
+        "pkg/mod.py",
+        '\nfrom abc import ABC\nfrom metaclass_registry import AutoRegisterMeta\n\n\nclass DerivedRegisteredFamilyMeta(AutoRegisterMeta):\n    pass\n\n\nclass DerivedRegisteredFamily(ABC, metaclass=DerivedRegisteredFamilyMeta):\n    __registry_key__ = "derived_key"\n    __skip_if_no_key__ = True\n\n\nclass PayloadCarrier(DerivedRegisteredFamily):\n    def mapping(self):\n        return {}\n\n\nclass AlphaPayload(PayloadCarrier):\n    def mapping(self):\n        return {"case": "alpha"}\n\n\nclass BetaPayload(PayloadCarrier):\n    def mapping(self):\n        return {"case": "beta"}\n',
+    )
+    assert not any(
+        finding.detector_id == "semantic_inheritance_family_ssot"
+        for finding in analyze_path(tmp_path)
+    )
+
+
 def test_detects_autoregister_meta_family_without_rent_proof(
     tmp_path: Path,
 ) -> None: