OIDC#2829
Open
constantine2nd wants to merge 5 commits into
Open
Conversation
OBP-API is used as a pure OAuth2 resource server: the client/BFF runs the OIDC
login against the provider (Keycloak) and calls OBP with Authorization: Bearer.
The server-side relying-party callback (/auth/openid-connect/callback{,-1,-2})
that minted a DirectLogin token was unused in this model and is removed.
- delete Http4sOpenIdConnect (routes, OpenIdConnectConfig, handler, helpers)
- unmount its routes from Http4sApp
- drop now-orphaned DirectLogin.issueTokenForUser (only caller was the callback)
- inline the "OpenID Connect" consumer-description constant in OAuth2
- delete the callback's two test suites
- update the stale Boot comment
Bearer-JWT validation (OAuth2Login / oauth2.keycloak.*) is unchanged;
Google-via-Keycloak login verified working after a clean rebuild.
…lback Add a polymorphic bill/utility payment to v7.0.0: POST /banks/BANK_ID/accounts/ACCOUNT_ID/VIEW_ID/transaction-request-types/ UTILITY/transaction-requests. The destination biller is a QualifiedIdentifier whose scheme must be a registered routing scheme of category UTILITY or BILL (e.g. TZ.UTILITY_METER for a prepaid electricity meter, TZ.BILL_CONTROL_NUMBER for a bill). One endpoint serves all utility/bill rails; verify the destination via POST .../payees/lookup, then pay quoting verified_payee_lookup_id (Confirmation-of-Payee handshake). Plugs into the existing createTransactionRequestv400 pipeline. - Http4s700: createTransactionRequestUtility endpoint + ResourceDoc - JSONFactory700: request/response shapes (payer block + callback block) + factory - ErrorMessages: OBP-30546..30549 - code.utilitypayment: UtilityPaymentCallback persistence + fire-and-forget OkHttp dispatcher; a failed/unreachable callback never fails the payment - Boot: register UtilityPaymentCallback table - commons: add UTILITY to TransactionRequestTypes enum - tests: 5 Http4s700RoutesTest scenarios (401, three 400s, 201 with persisted callback) Implementation is vendor-neutral: routing schemes and examples use generic names (TZ.UTILITY_METER, TZ.BILL_CONTROL_NUMBER) and placeholder sample data.
The OBP-as-relying-party OpenID Connect callback was removed in 91fa165; OBP-API is now a pure OAuth2 resource server (the client/BFF runs the OIDC login and calls OBP with a Bearer JWT). The openid_connect.* / openid_connect_$n.* props (enabled, check_session_state, show_tokens, response_mode/type, scope, and every per-provider client_id/client_secret/callback_url/endpoint.*/ button_text) have no readers left. Remove the dead block from sample.props.template, replace it with a breadcrumb pointing to the live oauth2.* resource-server props, and restore the OBP-OIDC oauth2 block to its original form.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.