Implemented NET472 tests to ensure parity.

Author: electricessence

Open.ChannelExtensions.Tests/BasicTests.cs

@@ -1,7 +1,9 @@
 using System;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
+using System.Threading;
 using System.Threading.Channels;
 using System.Threading.Tasks;
 using Xunit;
@@ -17,6 +19,7 @@ public static class BasicTests
 	[InlineData(testSize1)]
 	[InlineData(testSize2)]
 	[System.Diagnostics.CodeAnalysis.SuppressMessage("Reliability", "CA2012:Use ValueTasks correctly", Justification = "Testing only.")]
+	[System.Diagnostics.CodeAnalysis.SuppressMessage("CodeQuality", "IDE0079:Remove unnecessary suppression", Justification = "<Pending>")]
 	public static async Task DeferredWriteRead(int testSize)
 	{
 		IEnumerable<int> range = Enumerable.Range(0, testSize);
@@ -269,6 +272,7 @@ public static async Task BatchJoin(int testSize, int batchSize)
 		Assert.True(result.SequenceEqual(range));
 	}
 
+#if NET5_0_OR_GREATER
 	[Theory]
 	[InlineData(11)]
 	[InlineData(51)]
@@ -302,6 +306,7 @@ async IAsyncEnumerable<int> Samples()
 			}
 		}
 	}
+#endif
 
 	[Theory]
 	[InlineData(testSize1)]
@@ -326,5 +331,28 @@ public static async Task Filter(int testSize)
 		Assert.True(result.SequenceEqual(range.Where(i => i % 2 == 1)));
 	}
 
+	[Fact]
+	public static void PossibleSourceLoadingIssue()
+	{
+		int count_ = 0;
+
+		var queue = new BlockingCollection<int>();
+		var processingTask = StartProcessingTask2(queue.GetConsumingEnumerable());
+
+		for (var i = 0; i < 100000000; i++)
+			queue.Add(i);
 
+		queue.CompleteAdding();
+
+		processingTask.Wait();
+
+		Task StartProcessingTask2(IEnumerable<int> source)
+			=> Channel.CreateUnbounded<int>()
+				.Source(source, true)
+				.ReadAll(IncrementCount2)
+				.AsTask();
+
+		void IncrementCount2(int c)
+			=> Interlocked.Increment(ref count_);
+	}
 }

Open.ChannelExtensions.Tests/BatchTests.cs

@@ -273,7 +273,7 @@ public static async Task TimeoutTest1()
 	}
 
 
-
+	#if NET5_0_OR_GREATER
 	[Fact]
 	public static async Task BatchReadBehavior()
 	{
@@ -347,7 +347,6 @@ async ValueTask Dequeue()
 		}
 	}
 
-
 	[Fact]
 	public static async Task ReadBatchWithTimeoutEnumerableBakedIn()
 	{
@@ -393,6 +392,7 @@ public static async Task ReadBatchWithTimeoutEnumerableBakedIn()
 		Assert.Equal(3, i);
 		await c.Reader.Completion; // Propagate possible failure
 	}
+
 	public static async IAsyncEnumerable<IList<T>> ReadBatchEnumerableAsyncBakedIn<T>(
 		this ChannelReader<T> channelReader,
 		int batchSize,
@@ -421,6 +421,6 @@ public static async IAsyncEnumerable<IList<T>> ReadBatchEnumerableAsyncBakedIn<T
 			if (item?.Count > 0) yield return item;
 		}
 	}
-
+#endif
 }
 

Open.ChannelExtensions.Tests/Open.ChannelExtensions.Tests.csproj

@@ -1,26 +1,26 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <OutputType>Exe</OutputType>
-    <TargetFramework>net5.0</TargetFramework>
-    <LangVersion>latest</LangVersion>
+	<PropertyGroup>
+		<OutputType>Exe</OutputType>
+		<TargetFrameworks>net472; net5.0;</TargetFrameworks>
+		<LangVersion>latest</LangVersion>
 		<IsPackable>false</IsPackable>
 	</PropertyGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\Open.ChannelExtensions\Open.ChannelExtensions.csproj" />
-  </ItemGroup>
+	<ItemGroup>
+		<ProjectReference Include="..\Open.ChannelExtensions\Open.ChannelExtensions.csproj" />
+	</ItemGroup>
 
 	<ItemGroup>
 		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.10.0" />
 		<PackageReference Include="xunit" Version="2.4.1" />
 		<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
-		  <PrivateAssets>all</PrivateAssets>
-		  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
 		<PackageReference Include="coverlet.collector" Version="3.0.3">
-		  <PrivateAssets>all</PrivateAssets>
-		  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
 	</ItemGroup>
 

Open.ChannelExtensions.Tests/Program.cs

@@ -0,0 +1,8 @@
+namespace Open.ChannelExtensions.Tests;
+
+internal class Program
+{
+#if NET472
+	public static void Main(string[] args) {}
+#endif
+}