Skip to content

Element Representation Classes are Trivial Wrappers #539

Description

@rammann

All the elements in src/BeamlineCore come with a representation wrapper class.
In OPAL this representation layer was also implemented for a subset of the elements. There it served as an abstraction to separate the field evaluation from other properties of the element.

The recent PRs Unify Element Class Hierarchy - #477 and General Element Placement and RBend/SBend - #485 implemented cleaner separation of field evaluation and geometry, as well as 3D placement.

As a result, the REP classes now are thin wrappers that serve only to provide the getter for the elements' geometry object.

It would be simple to add the geometry object as a member to the elements directly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

CleanupTo be used for all changes not changing the "real" source (Comments, white space...)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions