From 1360a8da942c412ece583405247a4b2cf718cc31 Mon Sep 17 00:00:00 2001 From: maheshchilukamri Date: Fri, 31 Jul 2026 00:50:23 -0500 Subject: [PATCH 1/2] Add tests for SQL errors on Eunomia --- tests/testthat/test-executeDqChecks.R | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/testthat/test-executeDqChecks.R b/tests/testthat/test-executeDqChecks.R index 5b04680d..3c67fda9 100644 --- a/tests/testthat/test-executeDqChecks.R +++ b/tests/testthat/test-executeDqChecks.R @@ -49,6 +49,9 @@ test_that("Execute all TABLE checks on Synthea/Eunomia", { ) expect_true(nrow(results$CheckResults) > 0) + + sqlErrors <- stats::na.omit(results$CheckResults$error) + expect_length(sqlErrors, 0) }) test_that("Execute FIELD checks on Synthea/Eunomia", { @@ -73,6 +76,9 @@ test_that("Execute FIELD checks on Synthea/Eunomia", { } ) expect_true(nrow(results$CheckResults) > 0) + + sqlErrors <- stats::na.omit(results$CheckResults$error) + expect_length(sqlErrors, 0) }) test_that("Execute CONCEPT checks on Synthea/Eunomia", { @@ -101,6 +107,9 @@ test_that("Execute CONCEPT checks on Synthea/Eunomia", { } ) expect_true(nrow(results$CheckResults) > 0) + + sqlErrors <- stats::na.omit(results$CheckResults$error) + expect_length(sqlErrors, 0) }) test_that("Execute observation period overlap check", { From fea8f4448f1b7cb76d3034b2394b15312ebdf274 Mon Sep 17 00:00:00 2001 From: maheshchilukamri Date: Fri, 31 Jul 2026 22:36:07 -0500 Subject: [PATCH 2/2] Fix plausibleGender SQL for multiple concept IDs --- inst/sql/sql_server/concept_plausible_gender.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/inst/sql/sql_server/concept_plausible_gender.sql b/inst/sql/sql_server/concept_plausible_gender.sql index 4c9180da..650f5b10 100755 --- a/inst/sql/sql_server/concept_plausible_gender.sql +++ b/inst/sql/sql_server/concept_plausible_gender.sql @@ -40,7 +40,7 @@ FROM ON cdmTable.person_id = c.subject_id AND c.cohort_definition_id = @cohortDefinitionId } - WHERE cdmTable.@cdmFieldName = @conceptId + WHERE cdmTable.@cdmFieldName IN (@conceptId) AND p.gender_concept_id <> {@plausibleGender == 'Male'} ? {8507} : {8532} /*violatedRowsEnd*/ ) violated_rows @@ -54,6 +54,6 @@ FROM ON cdmTable.person_id = c.subject_id AND c.cohort_definition_id = @cohortDefinitionId } - WHERE @cdmFieldName = @conceptId + WHERE @cdmFieldName IN (@conceptId) ) denominator ;