From f11b58a7a099b701c3d929ea2cded036a0a5dafd Mon Sep 17 00:00:00 2001
From: Wolfgang Walther <walther@technowledgy.de>
Date: Fri, 30 May 2025 18:21:16 +0200
Subject: [PATCH] workflows/check: run "checks" in one workflow

This introduces "check" as another category of jobs suitable for the
"Require status checks to pass" feature.

Checks as a category would include everything that is done before even
looking at the code: Right branch? Commit messages? Cherry-picked
correctly?

(commit messages are not checked, yet)
---
 .../{check-cherry-picks.yml => check.yml}     | 36 +++++++++++++------
 .github/workflows/no-channel.yml              | 30 ----------------
 2 files changed, 26 insertions(+), 40 deletions(-)
 rename .github/workflows/{check-cherry-picks.yml => check.yml} (86%)
 delete mode 100644 .github/workflows/no-channel.yml

diff --git a/.github/workflows/check-cherry-picks.yml b/.github/workflows/check.yml
similarity index 86%
rename from .github/workflows/check-cherry-picks.yml
rename to .github/workflows/check.yml
index 618c1cf9ffed1..b348bef5bfc0d 100644
--- a/.github/workflows/check-cherry-picks.yml
+++ b/.github/workflows/check.yml
@@ -1,29 +1,45 @@
-name: "Check cherry-picks"
+name: Check
 
 on:
   pull_request:
     paths:
-      - .github/workflows/check-cherry-picks.yml
+      - .github/workflows/check.yml
   pull_request_target:
-    branches:
-      - 'release-**'
-      - 'staging-**'
-      - '!staging-next'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.head_ref || github.run_id }}
   cancel-in-progress: true
 
-permissions:
-  pull-requests: write
+permissions: {}
 
 defaults:
   run:
     shell: bash
 
 jobs:
-  check:
-    name: cherry-pick-check
+  no-channel-base:
+    name: no channel base
+    if: |
+      startsWith(github.base_ref, 'nixos-') ||
+      startsWith(github.base_ref, 'nixpkgs-')
+    runs-on: ubuntu-24.04-arm
+    steps:
+      - run: |
+          cat <<EOF
+          The nixos-* and nixpkgs-* branches are pushed to by the channel
+          release script and should not be merged into directly.
+
+          Please target the equivalent release-* branch or master instead.
+          EOF
+          exit 1
+
+  cherry-pick:
+    if: |
+      github.event_name == 'pull_request' ||
+      startsWith(github.base_ref, 'release-') ||
+      (startsWith(github.base_ref, 'staging-') && github.base_ref != 'staging-next')
+    permissions:
+      pull-requests: write
     runs-on: ubuntu-24.04-arm
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
diff --git a/.github/workflows/no-channel.yml b/.github/workflows/no-channel.yml
deleted file mode 100644
index d02d422d5d719..0000000000000
--- a/.github/workflows/no-channel.yml
+++ /dev/null
@@ -1,30 +0,0 @@
-name: "No channel PR"
-
-on:
-  pull_request:
-    paths:
-      - .github/workflows/no-channel.yml
-  pull_request_target:
-
-permissions: {}
-
-defaults:
-  run:
-    shell: bash
-
-jobs:
-  fail:
-    if: |
-      startsWith(github.event.pull_request.base.ref, 'nixos-') ||
-      startsWith(github.event.pull_request.base.ref, 'nixpkgs-')
-    name: "This PR is targeting a channel branch"
-    runs-on: ubuntu-24.04-arm
-    steps:
-      - run: |
-          cat <<EOF
-          The nixos-* and nixpkgs-* branches are pushed to by the channel
-          release script and should not be merged into directly.
-
-          Please target the equivalent release-* branch or master instead.
-          EOF
-          exit 1