Skip to content

Commit 91bb198

Browse files
Naaremanclaude
andcommitted
Fix final review items: uv sync --dev, reference table, polish
- uv sync --dev → --group dev in docs workflow (consistency with CI) - Add 07-common-mistakes.md to SKILL.md reference table - Add fallback cross-reference in scaffold __init__.py example - Fix warnings.warn() closing paren indentation in lifecycle Round 3 review: 9.4/10, zero critical issues, ready to ship. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 5a7227a commit 91bb198

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

SKILL.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ relevant reference file from `references/`:
3131
| Setting up or writing documentation | [references/04-docs.md](references/04-docs.md) |
3232
| Adding deprecations or managing versions | [references/05-lifecycle.md](references/05-lifecycle.md) |
3333
| Releasing to PyPI or setting up CI/CD | [references/06-release.md](references/06-release.md) |
34+
| Auditing for common anti-patterns | [references/07-common-mistakes.md](references/07-common-mistakes.md) |
3435

3536
Read only what's relevant to the current task. Don't load everything at once.
3637

references/01-scaffold.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ __all__ = [
136136
"ValidationError",
137137
]
138138

139-
__version__ = version("my-package")
139+
__version__ = version("my-package") # add PackageNotFoundError fallback if needed (see 07-common-mistakes.md)
140140
```
141141

142142
R equivalent: the `NAMESPACE` file — explicit exports only.

references/05-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def read_data(path): # OLD name
4949
"'read_data()' is deprecated, use 'read_csv()' instead.",
5050
DeprecationWarning,
5151
stacklevel=2, # points to the caller, not this function
52-
)
52+
)
5353
return read_csv(path)
5454
```
5555

references/06-release.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ jobs:
165165
uses: astral-sh/setup-uv@v4
166166
167167
- name: Install dependencies
168-
run: uv sync --dev
168+
run: uv sync --group dev
169169
170170
- name: Deploy docs
171171
run: uv run mkdocs gh-deploy --force

0 commit comments

Comments
 (0)