Merge branch 'develop' of github.com:MetaCell/cloud-harness into feature/CH-110

Author: filippomc

tools/deployment-cli-tools/ch_cli_tools/openapi.py

@@ -156,11 +156,11 @@ def generate_openapi_from_ninja_schema(app_name: str, app_path: pathlib.Path) ->
     # check if cloudharness_django python library is installed
     python_module = to_python_module(app_name)
     try:
-        import cloudharness_django
-        # dynamicall import python_module
-        __import__(f'{python_module}')
+        import cloudharness_django  # noqa
+        # dynamically import python_module
+        __import__(python_module)
     except ImportError:
-        if confirm('Runtime env is not installed. Do you want to install it? [Y/n]'):
+        if confirm('Runtime env is not installed. Do you want to install it?'):
             subprocess.check_call(["sh", "dev-setup.sh"], cwd=app_path)
         else:
             logging.error('Runtime env is not installed. Cound not generate openapi files for Django Ninja.')

tools/deployment-cli-tools/ch_cli_tools/utils.py

@@ -180,9 +180,9 @@ def replaceindir(root_src_dir, source, replace):
             replace_in_file(src_file, source, replace)
 
 
-def confirm(question, default_true=True):
+def confirm(question):
     answer = input(f"{question} (Y/n): ").casefold()
-    return (default_true and not answer) or answer == "y"
+    return answer == "y" if answer else True
 
 
 def replace_in_file(src_file: pathlib.Path, source: str, replacement) -> None:

tools/deployment-cli-tools/harness-generate

@@ -17,13 +17,9 @@ def main():
     args = get_command_line_arguments()
     get_dependencies()
 
-    if args.path:
-        root_path = args.path.absolute()
+    root_path = args.path.absolute()
 
-    else:
-        root_path = pathlib.Path.cwd()
-
-       # Check if applications folder exists, if not, go up until it's found
+    # Check if applications folder exists, if not, go up until it's found
     while not (root_path / 'applications').exists():
         if root_path == root_path.parent:
             logging.error('Could not find applications folder')