Skip to content

Commit d4937fb

Browse files
CH-67 Make events listener initialization an explicit action instead of implicit on import
1 parent 795b7d4 commit d4937fb

4 files changed

Lines changed: 13 additions & 7 deletions

File tree

  • application-templates/django-app/backend/django_baseapp
  • infrastructure/common-images/cloudharness-django/libraries/cloudharness-django/cloudharness_django

application-templates/django-app/backend/django_baseapp/asgi.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,6 @@
2121
init_services()
2222

2323
# start the kafka event listener
24-
import cloudharness_django.services.events # noqa E402
24+
from cloudharness_django.services.events import init_listner # noqa E402
25+
26+
init_listner()

application-templates/django-app/backend/django_baseapp/wsgi.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,6 @@
2121
init_services()
2222

2323
# start the kafka event listener
24-
import cloudharness_django.services.events # noqa E402
24+
from cloudharness_django.services.events import init_listner # noqa E402
25+
26+
init_listner()

infrastructure/common-images/cloudharness-django/libraries/cloudharness-django/cloudharness_django/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ Quick start
4646
init_services()
4747
4848
# start the kafka event listener
49-
import cloudharness_django.services.events
49+
from cloudharness_django.services.events import init_listner # noqa E402
50+
51+
init_listner()
5052
```
5153
5254
4. Start the development server and visit http://127.0.0.1:8000/

infrastructure/common-images/cloudharness-django/libraries/cloudharness-django/cloudharness_django/services/events.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ def setup_event_service(self):
7979
pass
8080

8181

82-
# start services
83-
if not hasattr(settings, "PROJECT_NAME"):
84-
raise KeycloakOIDCNoProjectError("Project name not found, please set PROJECT_NAME in your settings module")
82+
def init_listener():
83+
if not hasattr(settings, "PROJECT_NAME"):
84+
raise KeycloakOIDCNoProjectError("Project name not found, please set PROJECT_NAME in your settings module")
8585

86-
KeycloakMessageService(settings.PROJECT_NAME).setup_event_service()
86+
KeycloakMessageService(settings.PROJECT_NAME).setup_event_service()

0 commit comments

Comments
 (0)