Skip to content

Commit 80fd917

Browse files
committed
Fix user quota set: extra config applied before user quotas
1 parent 74a63de commit 80fd917

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

  • applications/jupyterhub/src/harness_jupyter/harness_jupyter

applications/jupyterhub/src/harness_jupyter/harness_jupyter/jupyterhub.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -193,13 +193,6 @@ def change_pod_manifest(self: KubeSpawner):
193193

194194
# set user quota cpu/mem usage if value has a "value" else don't change the value
195195

196-
logging.info("Setting user quota cpu/mem usage")
197-
198-
set_key_value(self, key="cpu_guarantee", value=float(user_quotas.get("quota-ws-guaranteecpu", self.cpu_guarantee)))
199-
set_key_value(self, key="cpu_limit", value=float(user_quotas.get("quota-ws-maxcpu", self.cpu_limit)))
200-
set_key_value(self, key="mem_guarantee", value=user_quotas.get("quota-ws-guaranteemem", self.mem_guarantee), unit="G")
201-
set_key_value(self, key="mem_limit", value=user_quotas.get("quota-ws-maxmem", self.mem_limit), unit="G")
202-
203196
# Default value, might be overwritten by the app config
204197
self.storage_pvc_ensure = bool(self.pvc_name)
205198

@@ -253,6 +246,12 @@ def change_pod_manifest(self: KubeSpawner):
253246
except:
254247
logging.error("Error loading Spawner extra configuration", exc_info=True)
255248

249+
logging.info("Setting user quota cpu/mem usage")
250+
251+
set_key_value(self, key="cpu_guarantee", value=float(user_quotas.get("quota-ws-guaranteecpu", self.cpu_guarantee)))
252+
set_key_value(self, key="cpu_limit", value=float(user_quotas.get("quota-ws-maxcpu", self.cpu_limit)))
253+
set_key_value(self, key="mem_guarantee", value=user_quotas.get("quota-ws-guaranteemem", self.mem_guarantee), unit="G")
254+
set_key_value(self, key="mem_limit", value=user_quotas.get("quota-ws-maxmem", self.mem_limit), unit="G")
256255
# check if there is an applicationHook defined in the values.yaml
257256
# if so then execute the applicationHook function with "self" as parameter
258257
#

0 commit comments

Comments
 (0)