Skip to content

Commit 414ab71

Browse files
authored
Merge pull request #754 from MetaCell/fix/CH-130-CH-131
Fix typer dependency
2 parents 7d5c032 + d111732 commit 414ab71

4 files changed

Lines changed: 10 additions & 19 deletions

File tree

deployment/codefresh-test.yaml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,13 @@ steps:
1313
repo: '${{CF_REPO_OWNER}}/${{CF_REPO_NAME}}'
1414
revision: '${{CF_BRANCH}}'
1515
git: github
16-
post_main_clone:
17-
title: Post main clone
18-
type: parallel
19-
stage: prepare
20-
steps:
21-
- title: Cloning cloud-harness repository...
22-
type: git-clone
23-
stage: prepare
24-
repo: https://github.com/MetaCell/cloud-harness.git
25-
revision: '${{CLOUDHARNESS_BRANCH}}'
26-
working_directory: .
27-
git: github
2816
prepare_deployment:
2917
title: Prepare helm chart
3018
image: python:3.9.10
3119
stage: prepare
3220
working_directory: .
3321
commands:
34-
- bash cloud-harness/install.sh
22+
- bash install.sh
3523
- harness-deployment . -n test-${{NAMESPACE_BASENAME}} -d ${{DOMAIN}} -r ${{REGISTRY}}
3624
-rs ${{REGISTRY_SECRET}} -e test --write-env -N -i samples
3725
- cat deployment/.env >> ${{CF_VOLUME_PATH}}/env_vars_to_export

install.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ CURRENT_PATH=$(pwd)
44
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
55

66
cd $SCRIPT_DIR
7-
7+
pip install --upgrade pip
8+
cat requirements.txt
89
pip install -r requirements.txt
910

1011
cd $CURRENT_PATH

requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
-e libraries/models
22
-e libraries/cloudharness-utils
33
-e tools/deployment-cli-tools
4-
4+
colorama<0.5.0,>=0.4.3
5+
typer<0.12.0

tools/deployment-cli-tools/ch_cli_tools/codefresh.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,10 +261,11 @@ def add_unit_test_step(app_config: ApplicationHarnessConfig):
261261
image=image_tag_with_variables(app_name, tag, base_image_name),
262262
)
263263

264-
codefresh_steps_from_base_path(join(root_path, BASE_IMAGES_PATH), CD_BUILD_STEP_BASE,
265-
fixed_context=relpath(root_path, os.getcwd()), include=helm_values[KEY_TASK_IMAGES].keys())
266-
codefresh_steps_from_base_path(join(root_path, STATIC_IMAGES_PATH), CD_BUILD_STEP_STATIC,
267-
include=helm_values[KEY_TASK_IMAGES].keys())
264+
if helm_values[KEY_TASK_IMAGES]:
265+
codefresh_steps_from_base_path(join(root_path, BASE_IMAGES_PATH), CD_BUILD_STEP_BASE,
266+
fixed_context=relpath(root_path, os.getcwd()), include=helm_values[KEY_TASK_IMAGES].keys())
267+
codefresh_steps_from_base_path(join(root_path, STATIC_IMAGES_PATH), CD_BUILD_STEP_STATIC,
268+
include=helm_values[KEY_TASK_IMAGES].keys())
268269

269270
codefresh_steps_from_base_path(join(
270271
root_path, APPS_PATH), CD_BUILD_STEP_PARALLEL)

0 commit comments

Comments
 (0)