Skip to content

Commit 2da748e

Browse files
authored
Merge pull request #658 from MetaCell/feature/657
#657 chore: add support for auto pulling CloudHarness tasks onto JupyterHub nodes with the JH prepuller
2 parents 2c32339 + 04625ce commit 2da748e

2 files changed

Lines changed: 26 additions & 0 deletions

File tree

applications/jupyterhub/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,11 @@ harness:
2323
values: pool-highcpu # k8s highcpu instance pool
2424
matchPurpose: require # require | prefer | ignore
2525
```
26+
27+
## Customizations
28+
29+
CloudHarness pre puller of tasks images support
30+
To support the pre pulling of task images see (https://github.com/MetaCell/cloud-harness/issues/657)
31+
the template `templates/image-puller/_helpers-daemonset.tpl` has been changed (see line 167 and on)
32+
33+
TODO: remember to implement/revise this code after you have updated/changed the templates of JupyterHub

applications/jupyterhub/deploy/templates/image-puller/_helpers-daemonset.tpl

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,24 @@ spec:
165165
{{- . | toYaml | nindent 12 }}
166166
{{- end }}
167167
{{- end }}
168+
169+
{{- /* --- Pull CloudHarness tasks images --- */}}
170+
{{- range $k, $v := ( index .Values "task-images" ) }}
171+
- name: image-pull-{{ $k | replace "-" "" }}
172+
image: {{ $v }}
173+
command:
174+
- /bin/sh
175+
- -c
176+
- echo "Pulling complete"
177+
{{- with $.Values.apps.jupyterhub.prePuller.resources }}
178+
resources:
179+
{{- . | toYaml | nindent 12 }}
180+
{{- end }}
181+
{{- with $.Values.apps.jupyterhub.prePuller.containerSecurityContext }}
182+
securityContext:
183+
{{- . | toYaml | nindent 12 }}
184+
{{- end }}
185+
{{- end }}
168186
containers:
169187
- name: pause
170188
image: {{ .Values.apps.jupyterhub.prePuller.pause.image.name }}:{{ .Values.apps.jupyterhub.prePuller.pause.image.tag }}

0 commit comments

Comments
 (0)