Skip to content

Commit 29a12b6

Browse files
committed
CH-19 Fix issue with underscored service dependencies
1 parent 752e4cc commit 29a12b6

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

deployment-configuration/helm/templates/ingress.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
{{- define "deploy_utils.ingress.service" }}
1515
{{ $domain := .root.Values.domain }}
1616
{{ $secured_gatekeepers := and .root.Values.secured_gatekeepers }}
17-
{{ $app := get .root.Values.apps (print .service_name | snakecase) }}
17+
{{ $app := get .root.Values.apps .service_name}}
1818
- path: /proxy/{{ $app.harness.service.name }}/(.*)
1919
pathType: ImplementationSpecific
2020
backend:

tools/deployment-cli-tools/ch_cli_tools/configurationgenerator.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -574,8 +574,7 @@ def validate_dependencies(values):
574574
f"Bad build dependencies specified for application {app}: {','.join(not_found)} not found as built image")
575575

576576
if 'use_services' in app_values[KEY_HARNESS]:
577-
service_dependencies = {d['name'].replace(
578-
"-", "_") for d in app_values[KEY_HARNESS]['use_services']}
577+
service_dependencies = {d['name'] for d in app_values[KEY_HARNESS]['use_services']}
579578

580579
not_found = {d for d in service_dependencies if d not in all_apps}
581580
if not_found:

0 commit comments

Comments
 (0)