CH-169 implement application build exclusion based on image param

Author: filippomc

tools/deployment-cli-tools/ch_cli_tools/codefresh.py

@@ -173,6 +173,9 @@ def codefresh_steps_from_base_path(base_path, build_step, fixed_context=None, in
                         # Skip excluded apps
                         continue
 
+                    if app_config and not helm_values.apps[app_key].get('build', True):
+                        continue
+
                     if app_config and app_config.dependencies and app_config.dependencies.git:
                         for dep in app_config.dependencies.git:
                             step_name = f"clone_{basename(dep.url).replace('.', '_')}_{basename(dockerfile_relative_to_root).replace('.', '_')}"

tools/deployment-cli-tools/ch_cli_tools/helm.py

@@ -190,13 +190,15 @@ def create_app_values_spec(self, app_name, app_path, base_image_name=None, helm_
         else:
             build_dependencies = []
 
-        if len(image_paths) > 0:
+        deployment_values = values[KEY_HARNESS].get(KEY_DEPLOYMENT, {})
+        deployment_image = deployment_values.get('image', None) or values.get('image', None)
+        values['build'] = not bool(deployment_image)  # Used by skaffold and ci/cd to determine if the image should be built
+        if len(image_paths) > 0 and not deployment_image:
             image_name = image_name_from_dockerfile_path(os.path.relpath(
                 image_paths[0], os.path.dirname(app_path)), base_image_name)
-
-            values['image'] = self.image_tag(
+            deployment_values['image'] = self.image_tag(
                 image_name, build_context_path=app_path, dependencies=build_dependencies)
-        elif KEY_HARNESS in values and not values[KEY_HARNESS].get(KEY_DEPLOYMENT, {}).get('image', None) and values[
+        elif KEY_HARNESS in values and not deployment_image and values[
                 KEY_HARNESS].get(KEY_DEPLOYMENT, {}).get('auto', False):
             raise Exception(f"At least one Dockerfile must be specified on application {app_name}. "
                             f"Specify harness.deployment.image value if you intend to use a prebuilt image.")

tools/deployment-cli-tools/ch_cli_tools/skaffold.py

@@ -81,6 +81,8 @@ def process_build_dockerfile(
         if app_name is None:
             app_name = app_name_from_path(basename(dockerfile_path))
         app_key = app_name.replace("-", "_")
+        if app_key in helm_values.apps and not helm_values.apps[app_key]['build']:
+            return
         if app_name in helm_values[KEY_TASK_IMAGES] or app_key in helm_values.apps:
             context_path = relpath_if(root_path, output_path) if global_context else relpath_if(dockerfile_path, output_path)
 
@@ -157,6 +159,8 @@ def process_build_dockerfile(
             #     app_image_tag, app_relative_to_skaffold, build_requirements)
             process_build_dockerfile(dockerfile_path, root_path, requirements=build_requirements, app_name=app_name)
             app = apps[app_key]
+            if not app['build']:
+                continue
             if app[KEY_HARNESS][KEY_DEPLOYMENT]['image']:
                 release_config['artifactOverrides']['apps'][app_key] = \
                     {