Skip to content

Tier 2: drive shake baseline 38 → 0 #53

@Xinze-Li-Moqian

Description

@Xinze-Li-Moqian

Part of umbrella #48.

Scope

lake exe shake OpenGALib --no-downstream currently reports 38 unused-import-or-missing-transitive-import suggestions (CI baseline EXPECTED_SHAKE=38). Drive this to 0 mechanically.

Approach

  1. Run lake exe shake OpenGALib --no-downstream to see current suggestions
  2. For each suggestion:
    • Remove an unused import — straightforward
    • Add a missing transitive-relied-on import — follow shake's suggestion
  3. Bump EXPECTED_SHAKE in .github/workflows/ci.yml after each batch

Acceptance

  • EXPECTED_SHAKE=0 in CI
  • lake exe shake OpenGALib --no-downstream reports 0 suggestions
  • Full lake build clean

Suggested split

4-6 PRs, each removing 5-15 import edits. Lower priority than Tier 1 — can be done opportunistically during other work.

Notes

Both maintainers assigned. Non-conflicting with most other work; safe to interleave with Tier 1. Coordinate via comments to avoid bumping EXPECTED_SHAKE twice in stacked PRs.

Reference: docs/REFACTOR_PLAYBOOK.md / memory reference_shake_workflow.md for the --fix quirk and Mathlib-standard downstream-fix workflow.

Metadata

Metadata

Labels

refactorCode restructuring / reorganizationtech-debtKnown engineering debt to clean up

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions