Part of umbrella #48.
Scope
lake exe shake OpenGALib --no-downstream currently reports 38 unused-import-or-missing-transitive-import suggestions (CI baseline EXPECTED_SHAKE=38). Drive this to 0 mechanically.
Approach
- Run
lake exe shake OpenGALib --no-downstream to see current suggestions
- For each suggestion:
- Remove an unused import — straightforward
- Add a missing transitive-relied-on import — follow shake's suggestion
- Bump
EXPECTED_SHAKE in .github/workflows/ci.yml after each batch
Acceptance
EXPECTED_SHAKE=0 in CI
lake exe shake OpenGALib --no-downstream reports 0 suggestions
- Full
lake build clean
Suggested split
4-6 PRs, each removing 5-15 import edits. Lower priority than Tier 1 — can be done opportunistically during other work.
Notes
Both maintainers assigned. Non-conflicting with most other work; safe to interleave with Tier 1. Coordinate via comments to avoid bumping EXPECTED_SHAKE twice in stacked PRs.
Reference: docs/REFACTOR_PLAYBOOK.md / memory reference_shake_workflow.md for the --fix quirk and Mathlib-standard downstream-fix workflow.
Part of umbrella #48.
Scope
lake exe shake OpenGALib --no-downstreamcurrently reports 38 unused-import-or-missing-transitive-import suggestions (CI baselineEXPECTED_SHAKE=38). Drive this to 0 mechanically.Approach
lake exe shake OpenGALib --no-downstreamto see current suggestionsEXPECTED_SHAKEin.github/workflows/ci.ymlafter each batchAcceptance
EXPECTED_SHAKE=0in CIlake exe shake OpenGALib --no-downstreamreports 0 suggestionslake buildcleanSuggested split
4-6 PRs, each removing 5-15 import edits. Lower priority than Tier 1 — can be done opportunistically during other work.
Notes
Both maintainers assigned. Non-conflicting with most other work; safe to interleave with Tier 1. Coordinate via comments to avoid bumping
EXPECTED_SHAKEtwice in stacked PRs.Reference:
docs/REFACTOR_PLAYBOOK.md/ memoryreference_shake_workflow.mdfor the--fixquirk and Mathlib-standard downstream-fix workflow.