Skip to content

fs.rmdir() deprecated #267

Description

@kuenzign

When installing devtools extensions in electron 41.1.1, I get this warning thrown in the console:

(node:12656) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead

It seems that in downloadChromeExtension.ts, this

await fs.promises.rmdir(extensionFolder, {
  recursive: true,
});

should be changed to this instead

await fs.promises.rm(extensionFolder, {
  recursive: true,
});

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions