Skip to content

Commit a44b0e4

Browse files
committed
Merge branch '2.9'
2 parents 17f55a4 + 4db32a4 commit a44b0e4

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

docs/src/hal/general-ref.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Typical pins definitions look like these examples:
2020

2121
Occasionally, an abbreviated version of the name may be used, for example the second pin above could be simply called with _.output_ when it can be done without causing confusion.
2222

23-
[[sec:hal-gr:namming-conventions]]
23+
[[sec:hal-gr:naming-conventions]]
2424
== HAL General Naming Conventions(((HAL General Naming Conventions)))
2525

2626
Consistent naming conventions would make HAL much easier to use.

docs/src/hal/halmodule.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ Does the specified pin have a driving pin connected. +
273273
Returns True or False.
274274

275275
----
276-
h.in.pin_has_writer()
276+
hal.pin_has_writer('some-comp.pin-name')
277277
----
278278

279279
=== get_name

src/emc/usr_intf/pncconf/pncconf.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2140,10 +2140,10 @@ def init_mesa_options(self,boardnum):
21402140
dbg('Looking for firmware data %s'%self.d["mesa%d_firmware"% boardnum])
21412141
found = False
21422142
search = 0
2143-
model = self.widgets["mesa%d_firmware"% boardnum].get_model()
2144-
for search,item in enumerate(model):
2145-
dbg('%d,%s'%(search,model[search][0]))
2146-
if model[search][0] == self.d["mesa%d_firmware"% boardnum]:
2143+
combo_model = self.widgets["mesa%d_firmware"% boardnum].get_model()
2144+
for search,item in enumerate(combo_model):
2145+
dbg('%d,%s'%(search,combo_model[search][0]))
2146+
if combo_model[search][0] == self.d["mesa%d_firmware"% boardnum]:
21472147
self.widgets["mesa%d_firmware"% boardnum].set_active(search)
21482148
found = True
21492149
dbg('found firmware # %d'% search)
@@ -2152,9 +2152,10 @@ def init_mesa_options(self,boardnum):
21522152
dbg('firmware not found')
21532153
cur_firm = self.d['mesa%d_currentfirmwaredata'% boardnum][_PD._FIRMWARE]
21542154
dbg('looking for: %s'% cur_firm )
2155+
combo = self.widgets["mesa%d_firmware"% boardnum]
21552156
#self.widgets["mesa%d_firmware"% boardnum].set_active(0)
21562157
self._p.MESA_FIRMWAREDATA.append(self.d['mesa%d_currentfirmwaredata'% boardnum])
2157-
model.append((cur_firm,))
2158+
combo.append_text(cur_firm)
21582159
self.init_mesa_options(boardnum)
21592160
return
21602161
else:

0 commit comments

Comments
 (0)