Skip to content

Commit 22662bf

Browse files
authored
Merge pull request #3552 from Sigma1912/halui_fix_axis_and_mdi_command_pins
Halui fix axis and mdi command pins
2 parents 4e013dd + 6056696 commit 22662bf

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

src/emc/usr_intf/halui.cc

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -703,24 +703,26 @@ int halui_hal_init(void)
703703
retval = hal_pin_bit_newf(HAL_OUT, &(halui_data->joint_is_homed[num_joints]), comp_id, "halui.joint.selected.is-homed");
704704
if (retval < 0) return retval;
705705

706+
bool first_axis = true;
706707
for (axis_num=0; axis_num < EMCMOT_MAX_AXIS ; axis_num++) {
707708
if ( !(axis_mask & (1 << axis_num)) ) { continue; }
708709
char c = "xyzabcuvw"[axis_num];
709-
710710
retval = hal_pin_bit_newf(HAL_OUT, &(halui_data->axis_is_selected[axis_num]), comp_id, "halui.axis.%c.is-selected", c);
711711
if (retval < 0) return retval;
712-
retval = hal_pin_float_newf(HAL_OUT, &(halui_data->axis_pos_commanded[axis_num]), comp_id, "halui.axis.%c.pos-commanded", c);
712+
retval = hal_pin_float_newf(HAL_OUT, &(halui_data->axis_pos_commanded[axis_num]), comp_id, "halui.axis.%c.pos-commanded", c);
713713
if (retval < 0) return retval;
714-
retval = hal_pin_float_newf(HAL_OUT, &(halui_data->axis_pos_feedback[axis_num]), comp_id, "halui.axis.%c.pos-feedback", c);
714+
retval = hal_pin_float_newf(HAL_OUT, &(halui_data->axis_pos_feedback[axis_num]), comp_id, "halui.axis.%c.pos-feedback", c);
715715
if (retval < 0) return retval;
716-
retval = hal_pin_float_newf(HAL_OUT, &(halui_data->axis_pos_relative[axis_num]), comp_id, "halui.axis.%c.pos-relative", c);
716+
retval = hal_pin_float_newf(HAL_OUT, &(halui_data->axis_pos_relative[axis_num]), comp_id, "halui.axis.%c.pos-relative", c);
717717
if (retval < 0) return retval;
718+
if (first_axis) {
719+
// at startup, indicate first item is selected:
720+
*halui_data->joint_is_selected[0] = 1;
721+
*halui_data->axis_is_selected[axis_num] = 1;
722+
}
723+
first_axis = false;
718724
}
719725

720-
// at startup, indicate [0] item is selected:
721-
*halui_data->joint_is_selected[0] = 1;
722-
*halui_data->axis_is_selected[0] = 1;
723-
724726
retval = hal_pin_float_newf(HAL_OUT, &(halui_data->mv_value), comp_id, "halui.max-velocity.value");
725727
if (retval < 0) return retval;
726728
retval = hal_pin_float_newf(HAL_OUT, &(halui_data->fo_value), comp_id, "halui.feed-override.value");

0 commit comments

Comments
 (0)