Skip to content

Commit c7f1027

Browse files
committed
test(handler): pass CrlRevocationChecker mock to AEngineHandlerTest
OpenSslHandler now expects 13 constructor arguments after CrlRevocationChecker was injected via the DI chain (AEngineHandler ← CfsslHandler/OpenSslHandler). The test was still passing only 12, causing ArgumentCountError. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent a1550bf commit c7f1027

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

tests/php/Unit/Handler/CertificateEngine/AEngineHandlerTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use OCA\Libresign\Handler\CertificateEngine\OpenSslHandler;
1414
use OCA\Libresign\Service\CaIdentifierService;
1515
use OCA\Libresign\Service\CertificatePolicyService;
16+
use OCA\Libresign\Service\Crl\CrlRevocationChecker;
1617
use OCA\Libresign\Service\SubjectAlternativeNameService;
1718
use OCP\Files\AppData\IAppDataFactory;
1819
use OCP\IAppConfig;
@@ -34,6 +35,7 @@ final class AEngineHandlerTest extends \OCA\Libresign\Tests\Unit\TestCase {
3435
private CaIdentifierService $caIdentifierService;
3536
private LoggerInterface $logger;
3637
private SubjectAlternativeNameService $subjectAlternativeNameService;
38+
private CrlRevocationChecker $crlRevocationChecker;
3739

3840
public function setUp(): void {
3941
$this->config = \OCP\Server::get(IConfig::class);
@@ -49,6 +51,7 @@ public function setUp(): void {
4951
$this->caIdentifierService = \OCP\Server::get(CaIdentifierService::class);
5052
$this->logger = \OCP\Server::get(LoggerInterface::class);
5153
$this->subjectAlternativeNameService = \OCP\Server::get(SubjectAlternativeNameService::class);
54+
$this->crlRevocationChecker = $this->createMock(CrlRevocationChecker::class);
5255
}
5356

5457
private function getInstance(): OpenSslHandler {
@@ -65,6 +68,7 @@ private function getInstance(): OpenSslHandler {
6568
$this->logger,
6669
\OCP\Server::get(\OCA\Libresign\Db\CrlMapper::class),
6770
$this->subjectAlternativeNameService,
71+
$this->crlRevocationChecker,
6872
);
6973
}
7074

0 commit comments

Comments
 (0)