fix(ModalVerificationCode): keep modal open during signing request

On step 3, signDocument() was self-closing the modal immediately after
emitting 'change', causing a jarring UX: the modal disappeared while the
signing API call was still in-flight, leaving a spinner on a disappeared
dialog.

- Remove self-close from signDocument(); parent (Sign.vue) already calls
  actionHandler.closeModal() on both sync and async signing paths, so the
  modal closes at the right time after the request completes.
- Set loading=true in signDocument() so the dialog stays disabled and
  shows a spinner while the API call runs.
- Add watcher on signStore.errors to reset loading=false when the signing
  request fails, allowing the user to retry without being stuck.
- Async signing path is unaffected: Sign.vue closes the modal before
  transitioning to the progress screen.

Tests added to cover:
- signDocument emits change with token and does not emit close
- signStore.errors watcher resets loading on failure (both modes)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

src/tests/views/SignPDF/_partials/ModalVerificationCode.spec.ts

@@ -8,6 +8,7 @@ import { setActivePinia, createPinia } from 'pinia'
 import { mount } from '@vue/test-utils'
 import ModalVerificationCode from '@/views/SignPDF/_partials/ModalVerificationCode.vue'
 import { useSignMethodsStore } from '@/store/signMethods.js'
+import { useSignStore } from '@/store/sign.js'
 
 // Mock axios
 vi.mock('@nextcloud/axios', () => ({
@@ -186,6 +187,49 @@ describe('ModalVerificationCode (email mode)', () => {
 
 		expect(wrapper.vm.identityVerified).toBe(false)
 	})
+
+	it('signDocument sets loading=true, emits change with token and does NOT self-close', async () => {
+		signMethodsStore.settings.emailToken.hasConfirmCode = true
+		wrapper = mountEmail()
+
+		wrapper.vm.token = '123456'
+		wrapper.vm.identityVerified = true
+		await wrapper.vm.$nextTick()
+
+		wrapper.vm.signDocument()
+
+		expect(wrapper.vm.loading).toBe(true)
+		expect(wrapper.emitted('change')).toBeTruthy()
+		expect(wrapper.emitted('change')![0]).toEqual(['123456'])
+		expect(wrapper.emitted('close')).toBeFalsy()
+	})
+
+	it('signStore.errors watcher resets loading when signing fails', async () => {
+		signMethodsStore.settings.emailToken.hasConfirmCode = true
+		wrapper = mountEmail()
+
+		const signStore = useSignStore()
+		wrapper.vm.loading = true
+
+		signStore.setSigningErrors([{ message: 'Signing failed' }])
+		await wrapper.vm.$nextTick()
+
+		expect(wrapper.vm.loading).toBe(false)
+	})
+
+	it('signStore.errors watcher does NOT reset loading when loading is already false', async () => {
+		signMethodsStore.settings.emailToken.hasConfirmCode = true
+		wrapper = mountEmail()
+
+		const signStore = useSignStore()
+		wrapper.vm.loading = false
+
+		signStore.setSigningErrors([{ message: 'Signing failed' }])
+		await wrapper.vm.$nextTick()
+
+		// loading was already false, no change expected
+		expect(wrapper.vm.loading).toBe(false)
+	})
 })
 
 describe('ModalVerificationCode (token mode)', () => {
@@ -370,4 +414,32 @@ describe('ModalVerificationCode (token mode)', () => {
 		expect(wrapper.vm.token).toBe('')
 		expect(wrapper.vm.identityVerified).toBe(false)
 	})
+
+	it('signDocument sets loading=true, emits change with token and does NOT self-close', async () => {
+		wrapper = mountToken({ phoneNumber: '+5511999999999' })
+
+		wrapper.vm.tokenRequested = true
+		wrapper.vm.token = '654321'
+		wrapper.vm.identityVerified = true
+		await wrapper.vm.$nextTick()
+
+		wrapper.vm.signDocument()
+
+		expect(wrapper.vm.loading).toBe(true)
+		expect(wrapper.emitted('change')).toBeTruthy()
+		expect(wrapper.emitted('change')![0]).toEqual(['654321'])
+		expect(wrapper.emitted('close')).toBeFalsy()
+	})
+
+	it('signStore.errors watcher resets loading when signing fails', async () => {
+		wrapper = mountToken({ phoneNumber: '+5511999999999' })
+
+		const signStore = useSignStore()
+		wrapper.vm.loading = true
+
+		signStore.setSigningErrors([{ message: 'Signing failed' }])
+		await wrapper.vm.$nextTick()
+
+		expect(wrapper.vm.loading).toBe(false)
+	})
 })

src/views/SignPDF/_partials/ModalVerificationCode.vue

@@ -124,7 +124,7 @@
 				{{ t('libresign', 'Sign document') }}
 			</NcButton>
 		</template>
-	</NcDialog>
+	</NcDialog>Step 1
 </template>
 
 <script>
@@ -279,6 +279,11 @@ export default {
 				this.signMethodsStore.setEmailToken(token)
 			}
 		},
+		'signStore.errors'(errors) {
+			if (errors && errors.length > 0 && this.loading) {
+				this.loading = false
+			}
+		},
 	},
 	methods: {
 		t,
@@ -377,10 +382,8 @@ export default {
 			this.identityVerified = true
 		},
 		signDocument() {
+			this.loading = true
 			this.$emit('change', this.token)
-			this.$nextTick(() => {
-				this.close()
-			})
 		},
 		close() {
 			if (this.mode === 'token') {