fix(crl): move ldap extension check from constructor to connect()

Throwing in the constructor of PhpLdapConnection crashed the DI container
on every request on servers that do not have the php-ldap extension installed,
even when no LDAP CRL URL was being checked.

Moving the guard to connect() keeps instantiation safe and lets the
existing RuntimeException catch-block in fetchFromLdap log a warning and
return null gracefully instead.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

lib/Service/Crl/Ldap/PhpLdapConnection.php

@@ -13,19 +13,16 @@
  * Production implementation of ILdapConnection that delegates every call
  * to the corresponding PHP ldap_* function.
  *
- * Requires the PHP ldap extension to be loaded. If the extension is missing
- * the constructor throws so the DI container can catch the problem early
- * rather than failing silently at connection time.
+ * If the PHP ldap extension is absent the class can still be instantiated;
+ * callers are expected to check function_exists('ldap_connect') before use.
  */
 class PhpLdapConnection implements ILdapConnection {
-	public function __construct() {
-		if (!function_exists('ldap_connect')) {
-			throw new \RuntimeException('PHP ldap extension is not loaded');
-		}
-	}
 
 	#[\Override]
 	public function connect(string $host, int $port): mixed {
+		if (!function_exists('ldap_connect')) {
+			throw new \RuntimeException('PHP ldap extension is not loaded');
+		}
 		$conn = @ldap_connect($host, $port);
 		if (!$conn) {
 			throw new \RuntimeException(sprintf('ldap_connect failed for %s:%d', $host, $port));