Skip to content

Commit 91d6191

Browse files
committed
test(crl): migrate SignersLoaderTest to CrlValidationStatus enum
Replaces the raw string literals 'valid' and 'revoked' in test fixtures with the typed CrlValidationStatus enum cases. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent 7ade45b commit 91d6191

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

tests/php/Unit/Service/File/SignersLoaderTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
use DateTime;
1212
use DateTimeInterface;
1313
use OCA\Libresign\Db\SignRequestMapper;
14+
use OCA\Libresign\Enum\CrlValidationStatus;
1415
use OCA\Libresign\Service\File\SignersLoader;
1516
use OCA\Libresign\Service\IdentifyMethodService;
1617
use OCA\Libresign\Service\SubjectAlternativeNameService;
@@ -368,7 +369,7 @@ public function testLoadSignersFromCertDataPreventsDuplicateFormattedDates(): vo
368369
'valid_from' => 'January 28, 2026, 11:58:51 PM',
369370
'valid_to' => 'January 29, 2026, 11:58:51 PM',
370371
'crl_urls' => ['http://localhost/index.php/apps/libresign/crl/libresign_g0sm1ngk87_29_o.crl'],
371-
'crl_validation' => 'revoked',
372+
'crl_validation' => CrlValidationStatus::REVOKED,
372373
'crl_revoked_at' => '2026-01-28T23:58:53+00:00',
373374
'signature_validation' => ['id' => 1, 'label' => 'Signature is valid.'],
374375
'isLibreSignRootCA' => true,
@@ -479,7 +480,7 @@ function (array $signers) {
479480
'hash' => 'endentity123',
480481
'serialNumber' => '111',
481482
'isLibreSignRootCA' => true,
482-
'crl_validation' => 'valid',
483+
'crl_validation' => CrlValidationStatus::VALID,
483484
'validFrom_time_t' => 1609459200, // 2021-01-01
484485
'validTo_time_t' => 1640995200, // 2022-01-01
485486
],
@@ -501,7 +502,7 @@ function (array $signers) {
501502
$signer = $signers[0];
502503
assert($signer->hash === 'endentity123', 'root hash should be from chain[0]');
503504
assert($signer->serialNumber === '111', 'root serialNumber should be from chain[0]');
504-
assert($signer->crl_validation === 'valid', 'root crl_validation should be from chain[0]');
505+
assert($signer->crl_validation === CrlValidationStatus::VALID, 'root crl_validation should be from chain[0]');
505506
assert($signer->chain[1]['hash'] === 'cacert456', 'chain[1] should retain its hash');
506507
assert($signer->chain[1]['serialNumber'] === '222', 'chain[1] should retain its serialNumber');
507508
},

0 commit comments

Comments
 (0)