test: cover file payload mapping and emptyFile mutation guard

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

src/tests/store/files.spec.ts

@@ -1107,5 +1107,88 @@ describe('files store - critical business rules', () => {
 			expect(store.selectedFileId).toBe(12)
 			expect(store.ordered).toContain(12)
 		})
+
+		/**
+		 * Regression: POST /request-signature missing "file" parameter.
+		 *
+		 * When init.ts uploads a file and the WebDAV PROPFIND response is missing
+		 * the Nextcloud-specific fileid (because getDefaultPropfind() was not used),
+		 * AppFilesTab.update() receives fileInfo.id = '' and creates a temp object
+		 * { id: -0 = 0, nodeId: '' }. addFile() silently rejects this (both falsy),
+		 * selectedFileId stays 0, and getFile() returns the shared emptyFile reference.
+		 * The signer gets pushed into emptyFile.signers (mutation of shared state),
+		 * and saveOrUpdateSignatureRequest sends POST with signers but no "file".
+		 *
+		 * Correct path (after fix): init.ts uses getDefaultPropfind() → fileid is
+		 * populated → AppFilesTab creates a properly keyed temp file with a valid
+		 * negative id and a valid nodeId → saveOrUpdateSignatureRequest includes
+		 * file: { nodeId } in the request body.
+		 */
+		describe('RULE: file reference in request-signature payload (init.ts upload flow)', () => {
+			it('includes file.nodeId when file has a temporary negative id', async () => {
+				const store = useFilesStore()
+				// Simulate the state AppFilesTab creates when the LibreSign API has not
+				// yet indexed the file (fallback path in AppFilesTab.update):
+				// id is -nodeId (temporary), nodeId is the real Nextcloud file id.
+				const nodeId = 12345
+				const tempId = -nodeId
+				store.files[tempId] = {
+					id: tempId,
+					nodeId,
+					name: 'test.pdf',
+					signers: [{ email: 'signer@example.com', identify: 'signer@example.com' }],
+					signatureFlow: 'parallel',
+				}
+				store.selectedFileId = tempId
+
+				axiosMock.mockResolvedValue({
+					data: { ocs: { data: { id: nodeId, nodeId, signatureFlow: 'parallel', signers: [] } } },
+				})
+
+				await store.saveOrUpdateSignatureRequest({})
+
+				const config = axiosMock.mock.calls[0][0]
+				expect(config.data.file).toEqual({ nodeId })
+			})
+
+			it('includes file.fileId when file has a real positive LibreSign id', async () => {
+				const store = useFilesStore()
+				// Simulate the state when LibreSign already knows about the file
+				// (returned by getAllFiles after the /api/v1/file POST in init.ts).
+				store.files[7] = {
+					id: 7,
+					nodeId: 12345,
+					name: 'test.pdf',
+					signers: [{ email: 'signer@example.com', identify: 'signer@example.com' }],
+					signatureFlow: 'parallel',
+				}
+				store.selectedFileId = 7
+
+				axiosMock.mockResolvedValue({
+					data: { ocs: { data: { id: 7, nodeId: 12345, signatureFlow: 'parallel', signers: [] } } },
+				})
+
+				await store.saveOrUpdateSignatureRequest({})
+
+				const config = axiosMock.mock.calls[0][0]
+				expect(config.data.file).toEqual({ fileId: 7 })
+			})
+
+			it('does NOT mutate the shared emptyFile when no file is selected', () => {
+				const store = useFilesStore()
+				store.selectedFileId = 0  // nothing selected
+
+				const signer = { email: 'a@example.com', identify: 'a@example.com' }
+				// If emptyFile were mutated, the signerUpdate below would persist
+				// across store instances and corrupt subsequent tests.
+				store.signerUpdate(signer)
+
+				// Create a fresh store — it must start with empty signers
+				const store2 = useFilesStore()
+				store2.selectedFileId = 0
+				const file2 = store2.getFile()
+				expect(file2.signers).toHaveLength(0)
+			})
+		})
 	})
 })