Skip to content

Commit 83b60c6

Browse files
test(request): add regression test for duplicate signingOrder on enable
Covers the case where all signers arrive from the API with signingOrder: 1 (the backend default). Enabling sequential mode must reassign unique sequential orders to each signer. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent 494bcee commit 83b60c6

1 file changed

Lines changed: 17 additions & 0 deletions

File tree

src/tests/components/RightSidebar/RequestSignatureTab.spec.ts

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -793,6 +793,23 @@ describe('RequestSignatureTab - Critical Business Rules', () => {
793793
expect(filesStore.files[1].signers[1].signingOrder).toBe(2)
794794
})
795795

796+
it('reassigns sequential orders when all signers share the same signingOrder', async () => {
797+
// Signers saved via the API return signingOrder: 1 as default for all of them.
798+
// The old check (!signer.signingOrder) would skip them because !1 === false,
799+
// leaving both at order 1 and causing the backend to notify both simultaneously.
800+
await updateFile({
801+
signatureFlow: 'parallel',
802+
signers: [
803+
{ email: 'signer1@example.com', signed: [], signingOrder: 1 },
804+
{ email: 'signer2@example.com', signed: [], signingOrder: 1 },
805+
],
806+
})
807+
wrapper.vm.onPreserveOrderChange(true)
808+
await wrapper.vm.$nextTick()
809+
expect(filesStore.files[1].signers[0].signingOrder).toBe(1)
810+
expect(filesStore.files[1].signers[1].signingOrder).toBe(2)
811+
})
812+
796813
it('reverts to parallel when disabling', async () => {
797814
await wrapper.setData({ adminSignatureFlow: 'none' })
798815
await updateFile({

0 commit comments

Comments
 (0)