Merge pull request #7226 from LibreSign/hotfix/v12.3.2-requestsignaturetab-modal-urls

hotfix: v12.3.2 requestsignaturetab modal urls

Author: vitormattos

CHANGELOG.md

@@ -18,6 +18,12 @@ Types of changes:
 
 <!-- changelog-linker -->
 <!-- changelog-linker -->
+## 12.3.3 - 2026-03-06
+
+### Fixes
+- fix: avoid router resolution in request signature tab modal
+- test: cover modal urls in request signature tab
+
 ## 12.3.2 - 2026-03-06
 
 ### Fixes

appinfo/info.xml

@@ -25,7 +25,7 @@ Developed with ❤️ by [LibreCode](https://librecode.coop). Help us transform
 
 * [Donate with GitHub Sponsor: ![Donate using GitHub Sponsor](https://img.shields.io/static/v1?label=Sponsor&message=%E2%9D%A4&logo=GitHub&color=%23fe8e86)](https://github.com/sponsors/libresign)
 	]]></description>
-	<version>12.3.2</version>
+	<version>12.3.3</version>
 	<licence>agpl</licence>
 	<author mail="contact@librecode.coop" homepage="https://librecode.coop">LibreCode</author>
 	<types>

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "libresign",
   "description": "A app for signing documents",
-  "version": "12.3.2",
+  "version": "12.3.3",
   "license": "agpl",
   "private": true,
   "scripts": {

package.json

@@ -308,7 +308,6 @@ import svgSignal from '../../../img/logo-signal-app.svg?raw'
 import svgTelegram from '../../../img/logo-telegram-app.svg?raw'
 import { FILE_STATUS, SIGN_REQUEST_STATUS } from '../../constants.js'
 import { openDocument } from '../../utils/viewer.js'
-import router from '../../router/router'
 import { useFilesStore } from '../../store/files.js'
 import { useSidebarStore } from '../../store/sidebar.js'
 import { useSignStore } from '../../store/sign.js'
@@ -875,8 +874,7 @@ export default {
 			}
 
 			if (this.useModal) {
-				const route = router.resolve({ name: 'ValidationFileExternal', params: { uuid: targetUuid } })
-				this.modalSrc = route.href
+				this.modalSrc = generateUrl('/apps/libresign/p/validation/{uuid}', { uuid: targetUuid })
 				return
 			}
 			this.$router.push({ name: 'ValidationFile', params: { uuid: targetUuid } })
@@ -1026,8 +1024,7 @@ export default {
 
 			const uuid = file.signUuid
 			if (this.useModal) {
-				const route = router.resolve({ name: 'SignPDFExternal', params: { uuid } })
-				this.modalSrc = route.href
+				this.modalSrc = generateUrl('/apps/libresign/p/sign/{uuid}/pdf', { uuid })
 				return
 			}
 			this.signStore.setFileToSign(this.filesStore.getFile())

src/components/RightSidebar/RequestSignatureTab.vue

@@ -10,6 +10,18 @@ import type { useFilesStore as useFilesStoreType } from '../../../store/files.js
 let RequestSignatureTab: unknown
 import { FILE_STATUS } from '../../../constants.js'
 
+const { generateUrlMock } = vi.hoisted(() => ({
+	generateUrlMock: vi.fn((path: string, params?: Record<string, string | number>) => {
+		if (!params) {
+			return path
+		}
+
+		return Object.entries(params).reduce((url, [key, value]) => {
+			return url.replace(`{${key}}`, String(value))
+		}, path)
+	}),
+}))
+
 // Mock translation function
 ;(globalThis as typeof globalThis & { t: (app: string, msg: string) => string }).t = vi.fn((app: string, msg: string) => msg)
 
@@ -46,7 +58,7 @@ vi.mock('@nextcloud/dialogs')
 vi.mock('@nextcloud/axios')
 vi.mock('@nextcloud/router', () => ({
 	generateOcsUrl: vi.fn((path) => `/ocs${path}`),
-	generateUrl: vi.fn((path) => path),
+	generateUrl: (...args: Parameters<typeof generateUrlMock>) => generateUrlMock(...args),
 	getRootUrl: vi.fn(() => ''),
 }))
 
@@ -68,6 +80,7 @@ describe('RequestSignatureTab - Critical Business Rules', () => {
 
 	beforeEach(async () => {
 		setActivePinia(createPinia())
+		generateUrlMock.mockClear()
 		RequestSignatureTab = (await import('../../../components/RightSidebar/RequestSignatureTab.vue')).default
 		const { useFilesStore } = await import('../../../store/files.js')
 		filesStore = useFilesStore()
@@ -351,6 +364,28 @@ describe('RequestSignatureTab - Critical Business Rules', () => {
 		})
 	})
 
+	describe('RULE: modal navigation uses absolute generated URLs', () => {
+		it('uses generateUrl for validation modal links', async () => {
+			await wrapper.setProps({ useModal: true })
+			await updateFile({ uuid: 'validation-uuid' })
+
+			wrapper.vm.validationFile()
+
+			expect(generateUrlMock).toHaveBeenCalledWith('/apps/libresign/p/validation/{uuid}', { uuid: 'validation-uuid' })
+			expect(wrapper.vm.modalSrc).toBe('/apps/libresign/p/validation/validation-uuid')
+		})
+
+		it('uses generateUrl for signing modal links', async () => {
+			await wrapper.setProps({ useModal: true })
+			await updateFile({ signUuid: 'sign-uuid' })
+
+			await wrapper.vm.sign()
+
+			expect(generateUrlMock).toHaveBeenCalledWith('/apps/libresign/p/sign/{uuid}/pdf', { uuid: 'sign-uuid' })
+			expect(wrapper.vm.modalSrc).toBe('/apps/libresign/p/sign/sign-uuid/pdf')
+		})
+	})
+
 	describe('RULE: canEditSigningOrder when using ordered flow', () => {
 		beforeEach(async () => {
 			await updateFile({