test(install): cover async process pid handling

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

tests/php/Unit/Service/InstallServiceTest.php

@@ -13,6 +13,8 @@
 use OCA\Libresign\Service\CaIdentifierService;
 use OCA\Libresign\Service\Install\InstallService;
 use OCA\Libresign\Service\Install\SignSetupService;
+use OCA\Libresign\Service\Process\ProcessManager;
+use OCA\Libresign\Vendor\Symfony\Component\Process\Process;
 use OCP\Files\AppData\IAppDataFactory;
 use OCP\Http\Client\IClientService;
 use OCP\IAppConfig;
@@ -32,6 +34,7 @@ final class InstallServiceTest extends \OCA\Libresign\Tests\Unit\TestCase {
 	private SignSetupService&MockObject $ignSetupService;
 	private IAppDataFactory&MockObject $appDataFactory;
 	private CaIdentifierService&MockObject $caIdentifierService;
+	private ProcessManager&MockObject $processManager;
 
 	public function setUp(): void {
 		parent::setUp();
@@ -47,6 +50,7 @@ protected function getInstallService(): InstallService {
 		$this->ignSetupService = $this->createMock(SignSetupService::class);
 		$this->appDataFactory = $this->createMock(IAppDataFactory::class);
 		$this->caIdentifierService = $this->createMock(CaIdentifierService::class);
+		$this->processManager = $this->createMock(ProcessManager::class);
 		return new InstallService(
 			$this->cacheFactory,
 			$this->clientService,
@@ -57,6 +61,7 @@ protected function getInstallService(): InstallService {
 			$this->ignSetupService,
 			$this->appDataFactory,
 			$this->caIdentifierService,
+			$this->processManager,
 		);
 	}
 
@@ -168,4 +173,149 @@ public static function providerGetFolder(): array {
 			['x86_64', 'test/folder1/folder2', 'folder2'],
 		];
 	}
+
+	public function testGetInstallPidReadsMatchingPidFromRegistry(): void {
+		$installService = $this->getInstallService();
+		$installService->setResource('cfssl');
+
+		$this->processManager->expects($this->once())
+			->method('findRunningPid')
+			->with('install', $this->callback('is_callable'))
+			->willReturnCallback(function (string $_source, callable $filter): int {
+				return $filter([
+					'pid' => 123,
+					'context' => ['resource' => 'cfssl'],
+					'createdAt' => 123,
+				]) ? 123 : 0;
+			});
+
+		$actual = self::invokePrivate($installService, 'getInstallPid');
+
+		$this->assertSame(123, $actual);
+	}
+
+	public function testGetInstallPidValidatesRequestedPidAgainstResource(): void {
+		$installService = $this->getInstallService();
+		$installService->setResource('cfssl');
+
+		$this->processManager->expects($this->once())
+			->method('findRunningPid')
+			->with('install', $this->callback('is_callable'))
+			->willReturn(0);
+
+		$this->processManager->expects($this->once())
+			->method('unregister')
+			->with('install', 123);
+
+		$actual = self::invokePrivate($installService, 'getInstallPid', [123]);
+
+		$this->assertSame(0, $actual);
+	}
+
+	public function testGetInstallPidKeepsRequestedPidWhenResourceMatches(): void {
+		$installService = $this->getInstallService();
+		$installService->setResource('cfssl');
+
+		$this->processManager->expects($this->once())
+			->method('findRunningPid')
+			->with('install', $this->callback('is_callable'))
+			->willReturnCallback(function (string $_source, callable $filter): int {
+				return $filter([
+					'pid' => 321,
+					'context' => ['resource' => 'cfssl'],
+					'createdAt' => 123,
+				]) ? 321 : 0;
+			});
+
+		$this->processManager->expects($this->never())
+			->method('unregister');
+
+		$actual = self::invokePrivate($installService, 'getInstallPid', [321]);
+
+		$this->assertSame(321, $actual);
+	}
+
+	public function testRunAsyncRegistersPidWhenProcessStarts(): void {
+		$process = $this->createMock(Process::class);
+		$process->expects($this->once())
+			->method('setOptions')
+			->with(['create_new_console' => true]);
+		$process->expects($this->once())
+			->method('setTimeout')
+			->with(null);
+		$process->expects($this->once())
+			->method('start');
+		$process->expects($this->once())
+			->method('getPid')
+			->willReturn(321);
+
+		$installService = $this->getInstallServiceWithProcess($process);
+		$installService->setResource('cfssl');
+
+		$this->processManager->expects($this->once())
+			->method('register')
+			->with('install', 321, ['resource' => 'cfssl']);
+
+		self::invokePrivate($installService, 'runAsync');
+	}
+
+	public function testRunAsyncLogsErrorWhenPidIsMissing(): void {
+		$process = $this->createMock(Process::class);
+		$process->expects($this->once())
+			->method('setOptions')
+			->with(['create_new_console' => true]);
+		$process->expects($this->once())
+			->method('setTimeout')
+			->with(null);
+		$process->expects($this->once())
+			->method('start');
+		$process->expects($this->once())
+			->method('getPid')
+			->willReturn(null);
+
+		$installService = $this->getInstallServiceWithProcess($process);
+		$installService->setResource('cfssl');
+
+		$this->processManager->expects($this->never())
+			->method('register');
+		$this->logger->expects($this->once())
+			->method('error')
+			->with($this->stringContains('Error to get PID of background install proccess'));
+
+		self::invokePrivate($installService, 'runAsync');
+	}
+
+	private function getInstallServiceWithProcess(Process $process): InstallService&MockObject {
+		$this->cacheFactory = $this->createMock(ICacheFactory::class);
+		$this->clientService = $this->createMock(IClientService::class);
+		$this->certificateEngineFactory = $this->createMock(CertificateEngineFactory::class);
+		$this->config = $this->createMock(IConfig::class);
+		$this->appConfig = $this->createMock(IAppConfig::class);
+		$this->logger = $this->createMock(LoggerInterface::class);
+		$this->ignSetupService = $this->createMock(SignSetupService::class);
+		$this->appDataFactory = $this->createMock(IAppDataFactory::class);
+		$this->caIdentifierService = $this->createMock(CaIdentifierService::class);
+		$this->processManager = $this->createMock(ProcessManager::class);
+
+		$installService = $this->getMockBuilder(InstallService::class)
+			->setConstructorArgs([
+				$this->cacheFactory,
+				$this->clientService,
+				$this->certificateEngineFactory,
+				$this->config,
+				$this->appConfig,
+				$this->logger,
+				$this->ignSetupService,
+				$this->appDataFactory,
+				$this->caIdentifierService,
+				$this->processManager,
+			])
+			->onlyMethods(['createProcess'])
+			->getMock();
+
+		$installService->method('createProcess')
+			->willReturn($process);
+
+		return $installService;
+	}
 }